From: Iban Rodriguez <iban.rodriguez@ono.com>
To: David Kershner <david.kershner@unisys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Benjamin Romer <benjamin.romer@unisys.com>,
Tim Sell <Timothy.Sell@unisys.com>,
Neil Horman <nhorman@redhat.com>
Cc: sparmaintainer@unisys.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
Iban Rodriguez <iban.rodriguez@ono.com>
Subject: Staging: unisys/verisonic: Correct double unlock
Date: Sat, 2 Apr 2016 19:47:06 +0200 [thread overview]
Message-ID: <1459619226-9786-1-git-send-email-iban.rodriguez@ono.com> (raw)
'priv_lock' is unlocked twice. The first one is removed and
the function 'visornic_serverdown_complete' is now called with
'priv_lock' locked because 'devdata' is modified inside.
Signed-off-by: Iban Rodriguez <iban.rodriguez@ono.com>
---
drivers/staging/unisys/visornic/visornic_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c
index be0d057346c3..af03f2938fe9 100644
--- a/drivers/staging/unisys/visornic/visornic_main.c
+++ b/drivers/staging/unisys/visornic/visornic_main.c
@@ -368,7 +368,6 @@ visornic_serverdown(struct visornic_devdata *devdata,
}
devdata->server_change_state = true;
devdata->server_down_complete_func = complete_func;
- spin_unlock_irqrestore(&devdata->priv_lock, flags);
visornic_serverdown_complete(devdata);
} else if (devdata->server_change_state) {
dev_dbg(&devdata->dev->device, "%s changing state\n",
--
1.9.1
next reply other threads:[~2016-04-02 17:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-02 17:47 Iban Rodriguez [this message]
2016-04-02 23:20 ` Sell, Timothy C
2016-04-04 14:35 ` Neil Horman
2016-04-04 21:40 ` Sell, Timothy C
2016-04-05 14:57 ` Neil Horman
2016-04-05 15:49 ` Sell, Timothy C
2016-04-05 16:04 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459619226-9786-1-git-send-email-iban.rodriguez@ono.com \
--to=iban.rodriguez@ono.com \
--cc=Timothy.Sell@unisys.com \
--cc=benjamin.romer@unisys.com \
--cc=david.kershner@unisys.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sparmaintainer@unisys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®