From: Ming Lei <ming.lei@canonical.com>
To: Jens Axboe <axboe@fb.com>, linux-kernel@vger.kernel.org
Cc: linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Anton Altaparmakov <anton@tuxera.com>,
xfs@oss.sgi.com, Dave Chinner <david@fromorbit.com>,
drbd-dev@lists.linbit.com,
Philipp Reisner <philipp.reisner@linbit.com>,
Lars Ellenberg <lars.ellenberg@linbit.com>,
Boaz Harrosh <boaz@plexistor.com>,
Ming Lei <ming.lei@canonical.com>
Subject: [PATCH v2 3/8] block: mark 1st parameter of bvec_iter_advance as const
Date: Mon, 4 Apr 2016 00:31:04 +0800 [thread overview]
Message-ID: <1459701069-31406-4-git-send-email-ming.lei@canonical.com> (raw)
In-Reply-To: <1459701069-31406-1-git-send-email-ming.lei@canonical.com>
bvec_iter_advance() only writes the parameter of iterator,
so the base address of bvec can be marked as const safely.
Without the change, we can see compiling warning in the
following patch for implementing iterate_bvec(): lib/iov_iter.c
with bvec iterator.
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ming Lei <ming.lei@canonical.com>
---
include/linux/bvec.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/bvec.h b/include/linux/bvec.h
index e111124..0c6fa42 100644
--- a/include/linux/bvec.h
+++ b/include/linux/bvec.h
@@ -63,7 +63,8 @@ struct bvec_iter {
.bv_offset = bvec_iter_offset((bvec), (iter)), \
})
-static inline void bvec_iter_advance(struct bio_vec *bv, struct bvec_iter *iter,
+static inline void bvec_iter_advance(const struct bio_vec *bv,
+ struct bvec_iter *iter,
unsigned bytes)
{
WARN_ONCE(bytes > iter->bi_size,
--
1.9.1
next prev parent reply other threads:[~2016-04-03 16:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-03 16:31 [PATCH v2 0/8] block: prepare for multipage bvecs Ming Lei
2016-04-03 16:31 ` [PATCH v2 1/8] block: move bvec iterator into include/linux/bvec.h Ming Lei
2016-04-03 16:31 ` [PATCH v2 2/8] block: move two bvec structure into bvec.h Ming Lei
2016-04-03 18:12 ` kbuild test robot
2016-04-03 16:31 ` Ming Lei [this message]
2016-04-03 16:31 ` [PATCH v2 4/8] iov_iter: use bvec iterator to implement iterate_bvec() Ming Lei
2016-04-03 16:31 ` [PATCH v2 5/8] fs: xfs: replace BIO_MAX_SECTORS with BIO_MAX_PAGES Ming Lei
2016-04-03 16:31 ` [PATCH v2 6/8] block: bio: remove BIO_MAX_SECTORS Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459701069-31406-4-git-send-email-ming.lei@canonical.com \
--to=ming.lei@canonical.com \
--cc=anton@tuxera.com \
--cc=axboe@fb.com \
--cc=boaz@plexistor.com \
--cc=david@fromorbit.com \
--cc=drbd-dev@lists.linbit.com \
--cc=hch@infradead.org \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®