mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Haojian Zhuang <haojian.zhuang@marvell.com>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Lee Jones <lee.jones@linaro.org>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	Samuel Ortiz <sameo@linux.intel.com>
Subject: [PATCH 0/7] drivers/mfd: make max drivers explicitly non-modular
Date: Sun, 3 Apr 2016 17:24:12 -0400	[thread overview]
Message-ID: <1459718659-28316-1-git-send-email-paul.gortmaker@windriver.com> (raw)

For anyone new to the underlying goal of this cleanup, we are trying to
make driver code consistent with the Makefiles/Kconfigs that control them.

This means not using modular functions/macros for drivers that can never
be built as a module.  Some of the other downfalls this leads to are:

 (1) it is easy to accidentally write unused module_exit and remove code
 (2) it can be misleading when reading the source, thinking it can be
     modular when the Makefile and/or Kconfig prohibit it
 (3) it requires the include of the module.h header file which in turn
     includes nearly everything else, thus adding to CPP overhead.
 (4) it gets copied/replicated into other drivers and spreads like weeds.

There are quite a few in the mfd space, so rather than send a large
series, I'll try and batch them up into reasonable sized queues.  To that
end, here we fix up all the maxim drivers as the 1st mfd batch.

As always, the option exists for someone with the hardware and the desire
to extend the functionality to make any given driver tristate.  But given
the number of these tree wide and the fact that I can't test that new
extended functionality in all cases, I just make the code consistent with
the existing Kconfig/Makefile settings that restrict them to "bool".

Build tested on linux-next for arm, arm64 and x86-64 to ensure no typos
or similar issues crept in.

Paul.
---

Cc: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Haojian Zhuang <haojian.zhuang@marvell.com>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>

Paul Gortmaker (7):
  drivers/mfd: make max8925-i2c.c explicitly non-modular
  drivers/mfd: make max8997.c explicitly non-modular
  drivers/mfd: make max8998.c explicitly non-modular
  drivers/mfd: make max14577.c explicitly non-modular
  drivers/mfd: make max77686.c explicitly non-modular
  drivers/mfd: make max77693.c explicitly non-modular
  drivers/mfd: make max77843.c explicitly non-modular

 drivers/mfd/max14577.c    | 13 +------------
 drivers/mfd/max77686.c    | 26 ++------------------------
 drivers/mfd/max77693.c    | 34 +++-------------------------------
 drivers/mfd/max77843.c    | 24 ++----------------------
 drivers/mfd/max8925-i2c.c | 14 +-------------
 drivers/mfd/max8997.c     | 30 +++---------------------------
 drivers/mfd/max8998.c     | 27 +--------------------------
 7 files changed, 13 insertions(+), 155 deletions(-)

-- 
2.8.0

             reply	other threads:[~2016-04-03 21:24 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-03 21:24 Paul Gortmaker [this message]
2016-04-03 21:24 ` [PATCH 1/7] drivers/mfd: make max8925-i2c.c " Paul Gortmaker
2016-04-03 21:24 ` [PATCH 2/7] drivers/mfd: make max8997.c " Paul Gortmaker
2016-04-03 21:24 ` [PATCH 3/7] drivers/mfd: make max8998.c " Paul Gortmaker
2016-04-03 21:24 ` [PATCH 4/7] drivers/mfd: make max14577.c " Paul Gortmaker
2016-04-04  3:42   ` Krzysztof Kozlowski
2016-04-04 15:09     ` Paul Gortmaker
2016-04-05 14:24     ` Javier Martinez Canillas
2016-04-03 21:24 ` [PATCH 5/7] drivers/mfd: make max77686.c " Paul Gortmaker
2016-04-04  3:44   ` Krzysztof Kozlowski
2016-04-04 15:08     ` Paul Gortmaker
2016-04-04 15:21     ` Javier Martinez Canillas
2016-04-03 21:24 ` [PATCH 6/7] drivers/mfd: make max77693.c " Paul Gortmaker
2016-04-04  3:53   ` Krzysztof Kozlowski
2016-04-04 15:39     ` Paul Gortmaker
2016-04-05  2:06       ` Krzysztof Kozlowski
2016-04-03 21:24 ` [PATCH 7/7] drivers/mfd: make max77843.c " Paul Gortmaker
2016-04-04  8:11 ` [PATCH 0/7] drivers/mfd: make max drivers " Lee Jones
2016-04-04 13:51   ` Paul Gortmaker
2016-04-04 14:21     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459718659-28316-1-git-send-email-paul.gortmaker@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=cw00.choi@samsung.com \
    --cc=haojian.zhuang@marvell.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome