From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933275AbcDERLZ (ORCPT ); Tue, 5 Apr 2016 13:11:25 -0400 Received: from mail-pf0-f178.google.com ([209.85.192.178]:34121 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932975AbcDERLT (ORCPT ); Tue, 5 Apr 2016 13:11:19 -0400 From: Sudip Mukherjee To: Arnd Bergmann , Greg Kroah-Hartman , Kees Cook Cc: linux-kernel@vger.kernel.org, Sudip Mukherjee Subject: [PATCH 2/2] lkdtm: fix memory leak of base Date: Tue, 5 Apr 2016 22:41:06 +0530 Message-Id: <1459876266-18023-2-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1459876266-18023-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1459876266-18023-1-git-send-email-sudipm.mukherjee@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This case is supposed to read from a memory after it has been freed, but we missed freeing base if the memory 'val' could not be allocated. Signed-off-by: Sudip Mukherjee --- drivers/misc/lkdtm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/misc/lkdtm.c b/drivers/misc/lkdtm.c index 2f0b022..5b3a63c 100644 --- a/drivers/misc/lkdtm.c +++ b/drivers/misc/lkdtm.c @@ -458,8 +458,10 @@ static void lkdtm_do_action(enum ctype which) break; val = kmalloc(len, GFP_KERNEL); - if (!val) + if (!val) { + kfree(base); break; + } *val = 0x12345678; base[offset] = *val; -- 1.9.1