From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: devel@linuxdriverproject.org
Cc: linux-kernel@vger.kernel.org,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Alex Ng <alexng@microsoft.com>, Cathy Avery <cavery@redhat.com>
Subject: [PATCH 2/2] Drivers: hv: balloon: reset host_specified_ha_region
Date: Tue, 5 Apr 2016 19:21:14 +0200 [thread overview]
Message-ID: <1459876874-882-3-git-send-email-vkuznets@redhat.com> (raw)
In-Reply-To: <1459876874-882-1-git-send-email-vkuznets@redhat.com>
We set host_specified_ha_region = true on certain request but this is a
global state which stays 'true' forever. We need to reset it when we
receive a request where ha_region is not specified. I did not see any
real issues, the bug was found by code inspection.
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
drivers/hv/hv_balloon.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c
index 43af913..df35fb7 100644
--- a/drivers/hv/hv_balloon.c
+++ b/drivers/hv/hv_balloon.c
@@ -1400,6 +1400,7 @@ static void balloon_onchannelcallback(void *context)
* This is a normal hot-add request specifying
* hot-add memory.
*/
+ dm->host_specified_ha_region = false;
ha_pg_range = &ha_msg->range;
dm->ha_wrk.ha_page_range = *ha_pg_range;
dm->ha_wrk.ha_region_range.page_range = 0;
--
2.5.5
next prev parent reply other threads:[~2016-04-05 17:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 17:21 [PATCH 0/2] Drivers: hv: balloon: two memory hotplug fixes Vitaly Kuznetsov
2016-04-05 17:21 ` [PATCH 1/2] Drivers: hv: balloon: don't crash when memory is added in non-sorted order Vitaly Kuznetsov
2016-04-05 17:21 ` Vitaly Kuznetsov [this message]
2016-04-18 12:58 ` [PATCH 0/2] Drivers: hv: balloon: two memory hotplug fixes Vitaly Kuznetsov
2016-04-18 14:04 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459876874-882-3-git-send-email-vkuznets@redhat.com \
--to=vkuznets@redhat.com \
--cc=alexng@microsoft.com \
--cc=cavery@redhat.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®