From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
To: <linux-spi@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <broonie@kernel.org>,
Shubhrajyoti Datta <shubhraj@xilinx.com>
Subject: [PATCH 1/7] spi: cadence: Fix a check patch warning
Date: Tue, 5 Apr 2016 23:37:48 +0530 [thread overview]
Message-ID: <1459879674-13012-1-git-send-email-shubhraj@xilinx.com> (raw)
CHECK: Comparison to NULL could be written "!master"
+ if (master == NULL)
Signed-off-by: Shubhrajyoti Datta <shubhraj@xilinx.com>
---
drivers/spi/spi-cadence.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/spi/spi-cadence.c b/drivers/spi/spi-cadence.c
index 121a413..3acaac3 100644
--- a/drivers/spi/spi-cadence.c
+++ b/drivers/spi/spi-cadence.c
@@ -481,7 +481,7 @@ static int cdns_spi_probe(struct platform_device *pdev)
u32 num_cs;
master = spi_alloc_master(&pdev->dev, sizeof(*xspi));
- if (master == NULL)
+ if (!master)
return -ENOMEM;
xspi = spi_master_get_devdata(master);
--
1.7.1
next reply other threads:[~2016-04-05 18:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 18:07 Shubhrajyoti Datta [this message]
2016-04-05 18:07 ` [PATCH 2/7] spi: cadence: Remove _MASK and _OFFSET suffix Shubhrajyoti Datta
2016-04-05 18:07 ` [PATCH 3/7] spi: cadence: Fix probe error handling Shubhrajyoti Datta
2016-04-05 18:07 ` [PATCH 4/7] spi: cadance: Fix the Documentation Shubhrajyoti Datta
2016-04-05 18:07 ` [PATCH 5/7] spi: cadence: Runtime pm adaptation Shubhrajyoti Datta
2016-04-05 18:07 ` [PATCH 6/7] spi: cadence: Remove the clock enable and disable from suspend and resume Shubhrajyoti Datta
2016-04-05 18:07 ` [PATCH 7/7] spi: cadence: Return the error code for cdns_spi_suspend and cdns_spi_resume Shubhrajyoti Datta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459879674-13012-1-git-send-email-shubhraj@xilinx.com \
--to=shubhrajyoti.datta@xilinx.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=shubhraj@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®