From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09C8F22617F for ; Thu, 19 Dec 2024 15:26:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734621990; cv=none; b=B+wkfoDmaC8LaDBhBL9wW8FCDZnHq8C1j445/6ZrHCmKvJZ28KTtQBqCmQIq7wjNWCXgT+MI61zsW7ZlAgXMXMBQb/WsbPiW2jiRKe1FW6yRGkXX3jQObGJrq74WLfDAlyRVXUsPg+/oh2O6V5T9XQG9zhm8c4ZHKq9j9jutrxY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734621990; c=relaxed/simple; bh=15RrTWKQpHCq/hvcLugkHfHdil5oe73YrQ2pQ1CJlL0=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=fGoDc0MGyfnHBLxvZIa85WQt9P3WySbAxDiEsRqhPYroAqasWgRzHSGU5J0sHyIbh7uJtJuFQfkXQmWxrhPy8kWZQ+kK46qEtfek1Y+rzaX+vOkFQfWi9l+jKfh0kssfdrnINCR9HJVA0toXlHX9DPNpIH416vsTGykNZ4zrAcg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LgvlmS/X; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LgvlmS/X" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-435f8f29f8aso7031015e9.2 for ; Thu, 19 Dec 2024 07:26:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1734621987; x=1735226787; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=VQ7HZmEeCGMgy0e+vPaSllNgD7jxFlhgiuqO+Gf6oic=; b=LgvlmS/Xe1DbBaOh2EqvwcEOO6YusRBXskAlnyEyADAINemZ4uoxyNdQRgHQtKqsNT MV6oZniWv4Kq9XUVQ8YwoGWrtsswxPn6+MOTDj44owNPi9LB/B/tVBjxmKDvyLmAWXtb obtY7syLHbEiJoZOjODqNq/ULJ4Jpb69CcQaTCCHGCVFusiAU5aeJnvaijslrJk3+9k0 PltVSi3U3mAUkoOgfT6OaDlzviRbcpLf782u36qxGjdr6UDU4IeECcmkRh03Yx1lwVqn JG9ZSu2hT2yOM8Gnft0y4aC/3fLu7iejd+ymrtxNefdVegnZ1gBzRZTXv0zlACkpBI8A +Ebg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734621987; x=1735226787; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=VQ7HZmEeCGMgy0e+vPaSllNgD7jxFlhgiuqO+Gf6oic=; b=eafsYFa4OLKhHjhQbquyOob2L3pIcZ47OWimI6xHEwEwOUEW/qEQCpK/RyV3tGiqlw 7wXDeoEiKDuRmlEvbGz7vh9DNWoidLF0d1riUXwD0eJyZQz+rJz7AcdCUFohD1tDoIXv VhwgL2cy0ZQlga003TGtt/a+T8Pxlw5TInhuW3ts3sVTN83O/57zka7s24NOwNmqeUiF 7HGklikldCpR79fw3s/GC1lUe2+9qGwqlB1eoB2WF+2FRf1Ou0jt5uHp+kxsWMlDew01 6Mrb9PVBQeDTh2Va52Kvf5l9Hboi3hMgEwYHgDCgYo9i3bpmFccIID5pgJSxhwzPOm+X RdUw== X-Forwarded-Encrypted: i=1; AJvYcCWC+RM+furyjODBR3z/sSFNAyGiQq8L/q2b9eebl5P9nBEr9KqhbLq6KJmCxd/Jxn4kqXVVNIO78wUX77k=@vger.kernel.org X-Gm-Message-State: AOJu0YyEApy2yH8briHxpO9et7+BzvQmX7yZq7iIbbYw7Oy638jkPXC0 3VEmd6/OWibtXO+QOkbU9FmqyifrclWGaeYks1HZ/hclcsm18B2qK6c44jCdxoc= X-Gm-Gg: ASbGncuXsFNrX8hylaT3ECVEoC56OTt+7/1wSfsZUt4ujlHyg8rcw9fKXoAyV9oA0By buLMI2KIxIveEA4MTU8hutsgf+Dj2HDKa1/B3VPnRZCLSyx7KUcIUhXjtXb/PchidvWMuaFPW1n I0tLK/DX2dfmM0FLs5CO52X6nNnq+ji8icZzzW8IgxmNr/2c57DI/ac9Xd+mHFHd1zJ2tj0Hevw wzFeMOfnPcbKwsTY1N/hiTD1Jqp3myco6eTAlaD9zFlIIcRunj7wZyL7OZYwXyBjs2Wwo91hSjK O3QN8iUa/ToFWpLiJxyuPn2TQ0X1m3q8/g== X-Google-Smtp-Source: AGHT+IEy1xHzK9K7OC7FPc2fyDm4x3L6AUfcIgdgbQdf1FCaNr7K1xPzw5OtAxsv5OKQ4c4RA4lwuA== X-Received: by 2002:a05:600c:4fd3:b0:434:a929:42bb with SMTP id 5b1f17b1804b1-4365536f6camr66630715e9.18.1734621985918; Thu, 19 Dec 2024 07:26:25 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:a0fd:4342:76af:7533? ([2a01:e0a:982:cbb0:a0fd:4342:76af:7533]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c829235sm1779437f8f.15.2024.12.19.07.26.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Dec 2024 07:26:25 -0800 (PST) Message-ID: <145dd6ae-be08-4f19-9e9d-abc238b35b8c@linaro.org> Date: Thu, 19 Dec 2024 16:26:24 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v2 0/3] scsi: ufs: qcom: Suspend fixes To: manivannan.sadhasivam@linaro.org, Alim Akhtar , Avri Altman , Bart Van Assche , "James E.J. Bottomley" , "Martin K. Petersen" , Abel Vesa , Bjorn Andersson , Konrad Dybcio Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Amit Pundir , Nitin Rawat , stable@vger.kernel.org, Ram Kumar Dwivedi References: <20241213-ufs-qcom-suspend-fix-v2-0-1de6cd2d6146@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20241213-ufs-qcom-suspend-fix-v2-0-1de6cd2d6146@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/12/2024 14:53, Manivannan Sadhasivam via B4 Relay wrote: > Hi, > > This series fixes the several suspend issues on Qcom platforms. Patch 1 fixes > the resume failure with spm_lvl=5 suspend on most of the Qcom platforms. For > this patch, I couldn't figure out the exact commit that caused the issue. So I > used the commit that introduced reinit support as a placeholder. > > Patch 3 fixes the suspend issue on SM8550 and SM8650 platforms where UFS > PHY retention is not supported. Hence the default spm_lvl=3 suspend fails. So > this patch configures spm_lvl=5 as the default suspend level to force UFSHC/ > device powerdown during suspend. This supersedes the previous series [1] that > tried to fix the issue in clock drivers. > > This series is tested on Qcom SM8550 MTP and Qcom RB5 boards. > > [1] https://lore.kernel.org/linux-arm-msm/20241107-ufs-clk-fix-v1-0-6032ff22a052@linaro.org > > Signed-off-by: Manivannan Sadhasivam > --- > Changes in v2: > - Changed 'ufs_qcom_drvdata::quirks' type to 'enum ufshcd_quirks' > - Collected tags > - Link to v1: https://lore.kernel.org/r/20241211-ufs-qcom-suspend-fix-v1-0-83ebbde76b1c@linaro.org > > --- > Manivannan Sadhasivam (3): > scsi: ufs: qcom: Power off the PHY if it was already powered on in ufs_qcom_power_up_sequence() > scsi: ufs: qcom: Allow passing platform specific OF data > scsi: ufs: qcom: Power down the controller/device during system suspend for SM8550/SM8650 SoCs > > drivers/ufs/core/ufshcd-priv.h | 6 ------ > drivers/ufs/core/ufshcd.c | 1 - > drivers/ufs/host/ufs-qcom.c | 31 +++++++++++++++++++------------ > drivers/ufs/host/ufs-qcom.h | 5 +++++ > include/ufs/ufshcd.h | 2 -- > 5 files changed, 24 insertions(+), 21 deletions(-) > --- > base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37 > change-id: 20241211-ufs-qcom-suspend-fix-5618e9c56d93 > > Best regards, Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Neil Armstrong # on SM8650-QRD