From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-efi@vger.kernel.org, Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH] efi/apple-properties: Delete an error message for a failed memory allocation in unmarshal_devices()
Date: Tue, 13 Feb 2018 18:00:26 +0100 [thread overview]
Message-ID: <145f8fac-9297-b362-d89f-886632e2507f@users.sourceforge.net> (raw)
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 13 Feb 2018 17:52:10 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/firmware/efi/apple-properties.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/firmware/efi/apple-properties.c b/drivers/firmware/efi/apple-properties.c
index 9f6bcf173b0e..f5f3159df4d5 100644
--- a/drivers/firmware/efi/apple-properties.c
+++ b/drivers/firmware/efi/apple-properties.c
@@ -158,10 +158,8 @@ static int __init unmarshal_devices(struct properties_header *properties)
entry = kcalloc(dev_header->prop_count + 1, sizeof(*entry),
GFP_KERNEL);
- if (!entry) {
- dev_err(dev, "cannot allocate properties\n");
+ if (!entry)
goto skip_device;
- }
unmarshal_key_value_pairs(dev_header, dev, ptr, entry);
if (!entry[0].name)
--
2.16.1
next reply other threads:[~2018-02-13 17:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 17:00 SF Markus Elfring [this message]
2018-02-13 18:40 ` Lukas Wunner
2018-02-13 18:50 ` Joe Perches
2018-02-14 8:21 ` efi/apple-properties: Checking error handling " SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=145f8fac-9297-b362-d89f-886632e2507f@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=ard.biesheuvel@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome