From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDCCBC43217 for ; Sun, 13 Mar 2022 16:30:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235006AbiCMQbs (ORCPT ); Sun, 13 Mar 2022 12:31:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231217AbiCMQbq (ORCPT ); Sun, 13 Mar 2022 12:31:46 -0400 Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA5CD201AC; Sun, 13 Mar 2022 09:30:38 -0700 (PDT) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 2C07F22238; Sun, 13 Mar 2022 17:30:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1647189036; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mw7ua8bm47fSMOjBOWnSCPNMt3SK4yr5lqTmvLcR1t4=; b=cF/58OMBU/4htvb/BgKkVeVxAhzy13qrKC37ZZ6qy+Uoyt4WoViG94H5fsPmpxBGr0tezn hIwyc41YjBG9GtN5lCbU7tMN4b4q6+PxVB8qyKxNu5ZQk7KLh9ImY+bq8LwpBxSyZccbPA GmX8asMq/Fmf8gQlBHNvTmZJoy2ml+U= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sun, 13 Mar 2022 17:30:35 +0100 From: Michael Walle To: Krzysztof Kozlowski Cc: "David S . Miller" , Jakub Kicinski , Rob Herring , Andrew Lunn , Heiner Kallweit , Russell King , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Horatiu Vultur , Kavyasree Kotagiri Subject: Re: [PATCH net-next v2 1/3] dt-bindings: net: mscc-miim: add lan966x compatible In-Reply-To: <2d35127c-d4ef-6644-289a-5c10bcbbbf84@kernel.org> References: <20220313002536.13068-1-michael@walle.cc> <20220313002536.13068-2-michael@walle.cc> <08b89b3f-d0d3-e96f-d1c3-80e8dfd0798f@kernel.org> <2d35127c-d4ef-6644-289a-5c10bcbbbf84@kernel.org> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <145fc079ce8c266b8c2265aacfd3b077@walle.cc> X-Sender: michael@walle.cc Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [adding Horatiu and Kavyasree from Microchip] Am 2022-03-13 17:10, schrieb Krzysztof Kozlowski: > On 13/03/2022 11:47, Michael Walle wrote: >> Am 2022-03-13 10:47, schrieb Krzysztof Kozlowski: >>> On 13/03/2022 01:25, Michael Walle wrote: >>>> The MDIO controller has support to release the internal PHYs from >>>> reset >>>> by specifying a second memory resource. This is different between >>>> the >>>> currently supported SparX-5 and the LAN966x. Add a new compatible to >>>> distiguish between these two. > > Typo here, BTW. > >>>> >>>> Signed-off-by: Michael Walle >>>> --- >>>> Documentation/devicetree/bindings/net/mscc-miim.txt | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/mscc-miim.txt >>>> b/Documentation/devicetree/bindings/net/mscc-miim.txt >>>> index 7104679cf59d..a9efff252ca6 100644 >>>> --- a/Documentation/devicetree/bindings/net/mscc-miim.txt >>>> +++ b/Documentation/devicetree/bindings/net/mscc-miim.txt >>>> @@ -2,7 +2,7 @@ Microsemi MII Management Controller (MIIM) / MDIO >>>> ================================================= >>>> >>>> Properties: >>>> -- compatible: must be "mscc,ocelot-miim" >>>> +- compatible: must be "mscc,ocelot-miim" or "mscc,lan966x-miim" >>> >>> No wildcards, use one, specific compatible. >> >> I'm in a kind of dilemma here, have a look yourself: >> grep -r "lan966[28x]-" Documentation >> >> Should I deviate from the common "name" now? To make things >> worse, there was a similar request by Arnd [1]. But the >> solution feels like cheating ("lan966x" -> "lan966") ;) > > The previous 966x cases were added by one person from Microchip, so he > actually might know something. But do you know whether lan966x will > cover all current and future designs from Microchip? E.g. lan9669 (if > ever made) will be the same? Avoiding wildcard is the easiest, just > choose one implementation, e.g. "lan9662". So if Microchip would review/ack this it would be ok? I don't really have a strong opinion, I just want to avoid any inconsistencies. If no one from Microchip will answer, I'll use microchip,lan9668-miim. > Different topic is that all current lan966[28] are from Microchip and > you still add Microsemi, even though it was acquired by Microchip. > That's an inconsistency which should be rather fixed. Agreed, that was an oversight by me. >> On a side note, I understand that there should be no wildcards, >> because the compatible should target one specific implementation, >> right? But then the codename "ocelot" represents a whole series of >> chips. Therefore, names for whole families shouldn't be used neither, >> right? > > You're not adding "ocelot" now, so it is separate topic. However a > compatible like "mscc,ocelot" feels wrong, unless it is used as a > fallback (see: git grep 'apple,'). Sure, it was just a question for my understanding, not to make a point for a discussion. -michael