mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Crispin <blogic@openwrt.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: "Felix Fietkau" <nbd@openwrt.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Sean Wang (王志亘)" <sean.wang@mediatek.com>,
	netdev@vger.kernel.org, linux-mediatek@lists.infradead.org,
	linux-kernel@vger.kernel.org, "John Crispin" <blogic@openwrt.org>
Subject: [PATCH V2 8/8] net: mediatek: do not set the QID field in the TX DMA descriptors
Date: Thu,  7 Apr 2016 21:26:50 +0200	[thread overview]
Message-ID: <1460057210-55786-9-git-send-email-blogic@openwrt.org> (raw)
In-Reply-To: <1460057210-55786-1-git-send-email-blogic@openwrt.org>

The QID field gets set to the mac id. This made the DMA linked list queue
the traffic of each MAC on a different internal queue. However during long
term testing we found that this will cause traffic stalls as the multi
queue setup requires a more complete initialisation which is not part of
the upstream driver yet.

This patch removes the code setting the QID field, resulting in all
traffic ending up in queue 0 which works without any special setup.

Signed-off-by: John Crispin <blogic@openwrt.org>
---
 drivers/net/ethernet/mediatek/mtk_eth_soc.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index f9f8851..8163047 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -603,8 +603,7 @@ static int mtk_tx_map(struct sk_buff *skb, struct net_device *dev,
 			WRITE_ONCE(txd->txd1, mapped_addr);
 			WRITE_ONCE(txd->txd3, (TX_DMA_SWC |
 					       TX_DMA_PLEN0(frag_map_size) |
-					       last_frag * TX_DMA_LS0) |
-					       mac->id);
+					       last_frag * TX_DMA_LS0));
 			WRITE_ONCE(txd->txd4, 0);
 
 			tx_buf->skb = (struct sk_buff *)MTK_DMA_DUMMY_DESC;
-- 
1.7.10.4

      parent reply	other threads:[~2016-04-07 19:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-07 19:26 [PATCH V2 0/8] net: mediatek: make the driver pass stress tests John Crispin
2016-04-07 19:26 ` [PATCH V2 1/8] net: mediatek: watchdog_timeo was not set John Crispin
2016-04-07 19:26 ` [PATCH V2 2/8] net: mediatek: mtk_cal_txd_req() returns bad value John Crispin
2016-04-07 19:26 ` [PATCH V2 3/8] net: mediatek: remove superfluous reset call John Crispin
2016-04-07 19:26 ` [PATCH V2 4/8] net: mediatek: fix stop and wakeup of queue John Crispin
2016-04-07 19:26 ` [PATCH V2 5/8] net: mediatek: fix mtk_pending_work John Crispin
2016-04-07 22:00   ` kbuild test robot
2016-04-07 19:26 ` [PATCH V2 6/8] net: mediatek: fix TX locking John Crispin
2016-04-07 19:46   ` Sergei Shtylyov
2016-04-07 19:26 ` [PATCH V2 7/8] net: mediatek: move the pending_work struct to the device generic struct John Crispin
2016-04-07 19:26 ` John Crispin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1460057210-55786-9-git-send-email-blogic@openwrt.org \
    --to=blogic@openwrt.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nbd@openwrt.org \
    --cc=netdev@vger.kernel.org \
    --cc=sean.wang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®