mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wang Nan <wangnan0@huawei.com>
To: <acme@kernel.org>
Cc: <pi3orama@163.com>, <linux-kernel@vger.kernel.org>,
	<lizefan@huawei.com>, <wangnan0@huawei.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	David Ahern <dsahern@gmail.com>, Jiri Olsa <jolsa@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>
Subject: [PATCH] perf build: Fix syscall table dependency error
Date: Fri, 8 Apr 2016 06:35:25 +0000	[thread overview]
Message-ID: <1460097325-94911-1-git-send-email-wangnan0@huawei.com> (raw)

Commit 42abeef7e8df ("perf tools: Build syscall table .c header from
kernel's syscall_64.tbl") introduces archheaders dependency. It is
added to 'prepare', but not added directly to libperf-in.o, causes
following error:

 $ make -C ./tools/perf/ O=/tmp/xxxxx/ /tmp/xxxxx/libperf-in.o JOBS=1
 make: Entering directory `/xx/xx/tools/perf'
 BUILD:   Doing 'make -j1' parallel build

 Auto-detecting system features:
 ...                         dwarf: [ on  ]
 ...            dwarf_getlocations: [ on  ]
 <SNIP>
   CC       /tmp/xxxxx/util/map.o
   CC       /tmp/xxxxx/util/pstack.o
   CC       /tmp/xxxxx/util/session.o
   make[3]: *** No rule to make target `/tmp/xxxxx/arch/x86/include/generated/asm/syscalls_64.c', needed by `/tmp/xxxxx/util/syscalltbl.o'.  Stop.
   make[2]: *** [util] Error 2
   make[1]: *** [/tmp/xxxxx/libperf-in.o] Error 2
   make: *** [/tmp/xxxxx/libperf-in.o] Error 2
   make: Leaving directory `/home/w00229757/kernel-hydrogen/tools/perf'

In parallel building this missing dependency causes building error.

Add 'prepare' to libperf-in's dependency.

Signed-off-by: Wang Nan <wangnan0@huawei.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/Makefile.perf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 1469aea..bde8cba 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -433,7 +433,7 @@ $(patsubst perf-%,%.o,$(PROGRAMS)): $(wildcard */*.h)
 
 LIBPERF_IN := $(OUTPUT)libperf-in.o
 
-$(LIBPERF_IN): fixdep FORCE
+$(LIBPERF_IN): prepare fixdep FORCE
 	$(Q)$(MAKE) $(build)=libperf
 
 $(LIB_FILE): $(LIBPERF_IN)
-- 
1.8.3.4

             reply	other threads:[~2016-04-08  6:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-08  6:35 Wang Nan [this message]
2016-04-08 12:55 ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1460097325-94911-1-git-send-email-wangnan0@huawei.com \
    --to=wangnan0@huawei.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=dsahern@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=namhyung@kernel.org \
    --cc=pi3orama@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®