From: Denys Vlasenko <dvlasenk@redhat.com>
To: Ingo Molnar <mingo@redhat.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] lockdep: Deinline register_lock_class, save 2328 bytes
Date: Fri, 8 Apr 2016 20:58:46 +0200 [thread overview]
Message-ID: <1460141926-13069-5-git-send-email-dvlasenk@redhat.com> (raw)
In-Reply-To: <1460141926-13069-1-git-send-email-dvlasenk@redhat.com>
This function compiles to 1328 bytes of machine code. Three callsites.
Registering a new lock class is definitely not *that* time-critical to inline it.
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: Peter Zijlstra <peterz@infradead.org>
CC: Ingo Molnar <mingo@redhat.com>
CC: linux-kernel@vger.kernel.org
---
kernel/locking/lockdep.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
index 53ab2f8..ffad373 100644
--- a/kernel/locking/lockdep.c
+++ b/kernel/locking/lockdep.c
@@ -708,7 +708,7 @@ look_up_lock_class(struct lockdep_map *lock, unsigned int subclass)
* yet. Otherwise we look it up. We cache the result in the lock object
* itself, so actual lookup of the hash should be once per lock object.
*/
-static inline struct lock_class *
+static struct lock_class *
register_lock_class(struct lockdep_map *lock, unsigned int subclass, int force)
{
struct lockdep_subclass_key *key;
--
2.1.0
next prev parent reply other threads:[~2016-04-08 18:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 18:58 [PATCH] drivers/infiniband/hw/nes/nes_verbs.c: Deinline nes_free_qp_mem, save 1072 bytes Denys Vlasenko
2016-04-08 18:58 ` [PATCH] drivers/scsi/fnic/fnic_scsi.c: Deinline fnic_queue_abort_io_req, save 1792 bytes Denys Vlasenko
2016-04-08 19:08 ` Laurence Oberman
2016-04-12 2:16 ` Martin K. Petersen
2016-04-08 18:58 ` [PATCH] drivers/virtio/virtio_ring.c: Deinline virtqueue_add, save 1016 bytes Denys Vlasenko
2016-04-09 20:14 ` Michael S. Tsirkin
2016-04-08 18:58 ` [PATCH] fs/gfs2/glock.c: Deinline do_error, save 1856 bytes Denys Vlasenko
2016-04-08 19:17 ` Bob Peterson
2016-04-08 19:46 ` Denys Vlasenko
2016-04-12 16:49 ` Bob Peterson
2016-04-08 18:58 ` Denys Vlasenko [this message]
2016-04-13 11:28 ` [tip:locking/core] locking/lockdep: Deinline register_lock_class(), save 2328 bytes tip-bot for Denys Vlasenko
2016-04-11 4:41 ` [PATCH] drivers/infiniband/hw/nes/nes_verbs.c: Deinline nes_free_qp_mem, save 1072 bytes Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460141926-13069-5-git-send-email-dvlasenk@redhat.com \
--to=dvlasenk@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®