From: Yuyang Du <yuyang.du@intel.com>
To: peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org
Cc: bsegall@google.com, pjt@google.com, morten.rasmussen@arm.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
juri.lelli@arm.com, Yuyang Du <yuyang.du@intel.com>
Subject: [PATCH 3/4] sched/fair: Modify accumulated sums for load/util averages
Date: Mon, 11 Apr 2016 06:36:04 +0800 [thread overview]
Message-ID: <1460327765-18024-4-git-send-email-yuyang.du@intel.com> (raw)
In-Reply-To: <1460327765-18024-1-git-send-email-yuyang.du@intel.com>
After we dropped the incomplete period, the current period should be
a complete "past" period, since all period boundaries, in the past
or in the future, are predetermined.
With incomplete current period:
| | | | |
-------------------*
^ ^
| |
current
With this patch:
| | | | |
-------------------*
^ ^
| |
current
So, the precomputed sums in __accumulated_sum_N[] and
__accumulated_sum_N32[] should be updated accordingly.
Update the script to generate the constants:
print " #: inv_N sum_N"
print "-----------------------"
y = (0.5)**(1/32.0)
x = 2**32
xx = 1024
for i in range(0, 32):
if i == 0:
x = x-1
else:
x = x*y
xx = int(xx*y + 1024)
print "%2d: %#x %8d" % (i, int(x), int(xx))
print " #: sum_N32"
print "------------"
xxx = xx
for i in range(0, 11):
if i == 0:
xxx = xx
else:
xxx = xxx/2 + xx
print "%2d: %8d" % (i, xxx)
Signed-off-by: Yuyang Du <yuyang.du@intel.com>
---
kernel/sched/fair.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 68273e8..49e9f1a 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -666,7 +666,7 @@ static unsigned long task_h_load(struct task_struct *p);
*/
#define LOAD_AVG_PERIOD 32
#define LOAD_AVG_MAX 47742 /* maximum possible load avg */
-#define LOAD_AVG_MAX_N 345 /* number of full periods to produce LOAD_AVG_MAX */
+#define LOAD_AVG_MAX_N 347 /* number of full periods to produce LOAD_AVG_MAX */
/* Give new sched_entity start runnable values to heavy its load in infant time */
void init_entity_runnable_average(struct sched_entity *se)
@@ -2591,9 +2591,9 @@ static const u32 __decay_inv_multiply_N[] = {
* over-estimates when re-combining.
*/
static const u32 __accumulated_sum_N[] = {
- 0, 1002, 1982, 2941, 3880, 4798, 5697, 6576, 7437, 8279, 9103,
- 9909,10698,11470,12226,12966,13690,14398,15091,15769,16433,17082,
- 17718,18340,18949,19545,20128,20698,21256,21802,22336,22859,23371,
+ 0, 1024, 2026, 3006, 3965, 4904, 5822, 6721, 7600, 8461, 9303,
+ 10127,10933,11722,12494,13250,13990,14714,15422,16115,16793,17457,
+ 18106,18742,19364,19973,20569,21152,21722,22280,22826,23360,23883,
};
/*
@@ -2601,8 +2601,8 @@ static const u32 __accumulated_sum_N[] = {
* lower integers.
*/
static const u32 __accumulated_sum_N32[] = {
- 0, 23371, 35056, 40899, 43820, 45281,
- 46011, 46376, 46559, 46650, 46696, 46719,
+ 0, 23883, 35824, 41795, 44780, 46273,
+ 47019, 47392, 47579, 47672, 47719, 47742,
};
/*
--
2.1.4
next prev parent reply other threads:[~2016-04-11 6:19 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-10 22:36 [PATCH 0/4] Optimize sched avg computation and implement flat util hierarchy Yuyang Du
2016-04-10 22:36 ` [PATCH 1/4] sched/fair: Optimize sum computation with a lookup table Yuyang Du
2016-04-11 9:08 ` Vincent Guittot
2016-04-11 10:41 ` Juri Lelli
2016-04-11 19:12 ` Yuyang Du
2016-04-12 10:14 ` Juri Lelli
2016-04-12 18:07 ` Yuyang Du
2016-04-13 9:11 ` Juri Lelli
2016-04-11 16:59 ` Dietmar Eggemann
2016-04-11 19:17 ` Yuyang Du
2016-04-12 14:19 ` Peter Zijlstra
2016-04-12 18:12 ` Yuyang Du
2016-04-11 23:21 ` Joe Perches
2016-04-12 12:02 ` Juri Lelli
2016-04-11 23:07 ` Joe Perches
2016-04-10 22:36 ` [PATCH 2/4] sched/fair: Drop out incomplete current period when sched averages accrue Yuyang Du
2016-04-11 9:08 ` Vincent Guittot
2016-04-11 19:41 ` Yuyang Du
2016-04-12 11:56 ` Vincent Guittot
2016-04-12 21:09 ` Yuyang Du
2016-04-13 11:11 ` Vincent Guittot
2016-04-12 12:02 ` Dietmar Eggemann
2016-04-12 20:14 ` Yuyang Du
2016-04-13 4:04 ` Joe Perches
2016-04-13 8:40 ` Morten Rasmussen
2016-04-13 15:13 ` Dietmar Eggemann
2016-04-13 15:28 ` Vincent Guittot
2016-04-13 16:20 ` Vincent Guittot
2016-04-13 18:44 ` Yuyang Du
2016-04-14 12:52 ` Dietmar Eggemann
2016-04-14 20:05 ` Yuyang Du
2016-04-18 17:59 ` Yuyang Du
2016-04-10 22:36 ` Yuyang Du [this message]
2016-04-11 17:14 ` [PATCH 3/4] sched/fair: Modify accumulated sums for load/util averages Dietmar Eggemann
2016-04-10 22:36 ` [PATCH 4/4] sched/fair: Implement flat hierarchical structure for util_avg Yuyang Du
2016-04-11 12:29 ` Vincent Guittot
2016-04-11 20:37 ` Yuyang Du
2016-04-13 11:27 ` Vincent Guittot
2016-04-13 18:20 ` Yuyang Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460327765-18024-4-git-send-email-yuyang.du@intel.com \
--to=yuyang.du@intel.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®