From: Julien Grall <julien.grall@arm.com>
To: kvmarm@lists.cs.columbia.edu
Cc: christoffer.dall@linaro.org, marc.zyngier@arm.com,
fu.wei@linaro.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, wei@redhat.com,
al.stone@linaro.org, gg@slimlogic.co.uk, hanjun.guo@linaro.org,
Julien Grall <julien.grall@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>
Subject: [PATCH v6 03/10] irqchip/gic-v2: Gather ACPI specific data in a single structure
Date: Mon, 11 Apr 2016 16:32:53 +0100 [thread overview]
Message-ID: <1460388780-914-4-git-send-email-julien.grall@arm.com> (raw)
In-Reply-To: <1460388780-914-1-git-send-email-julien.grall@arm.com>
The ACPI code requires to use global variables in order to collect
information from the tables.
For now, a single global variable is used, but more will be added in a
subsequent patch. To make clear they are ACPI specific, gather all the
information in a single structure.
Signed-off-by: Julien Grall <julien.grall@arm.com>
Acked-by: Christofer Dall <christoffer.dall@linaro.org>
Acked-by: Hanjun Guo <hanjun.guo@linaro.org>
---
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Changes in v6:
- Add Hanjun's acked-by
Changes in v4:
- Update commit message
- Rename cpu_phy_base to cpu_phys_base
- Add Christopher's acked-by
Changes in v2:
- Patch added
---
drivers/irqchip/irq-gic.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
index 282344b..7a73786 100644
--- a/drivers/irqchip/irq-gic.c
+++ b/drivers/irqchip/irq-gic.c
@@ -1245,7 +1245,10 @@ IRQCHIP_DECLARE(pl390, "arm,pl390", gic_of_init);
#endif
#ifdef CONFIG_ACPI
-static phys_addr_t cpu_phy_base __initdata;
+static struct
+{
+ phys_addr_t cpu_phys_base;
+} acpi_data __initdata;
static int __init
gic_acpi_parse_madt_cpu(struct acpi_subtable_header *header,
@@ -1265,10 +1268,10 @@ gic_acpi_parse_madt_cpu(struct acpi_subtable_header *header,
* All CPU interface addresses have to be the same.
*/
gic_cpu_base = processor->base_address;
- if (cpu_base_assigned && gic_cpu_base != cpu_phy_base)
+ if (cpu_base_assigned && gic_cpu_base != acpi_data.cpu_phys_base)
return -EINVAL;
- cpu_phy_base = gic_cpu_base;
+ acpi_data.cpu_phys_base = gic_cpu_base;
cpu_base_assigned = 1;
return 0;
}
@@ -1316,7 +1319,7 @@ static int __init gic_v2_acpi_init(struct acpi_subtable_header *header,
return -EINVAL;
}
- cpu_base = ioremap(cpu_phy_base, ACPI_GIC_CPU_IF_MEM_SIZE);
+ cpu_base = ioremap(acpi_data.cpu_phys_base, ACPI_GIC_CPU_IF_MEM_SIZE);
if (!cpu_base) {
pr_err("Unable to map GICC registers\n");
return -ENOMEM;
--
1.9.1
next prev parent reply other threads:[~2016-04-11 15:33 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 15:32 [PATCH v6 00/10] arm64: Add support for KVM with ACPI Julien Grall
2016-04-11 15:32 ` [PATCH v6 01/10] clocksource: arm_arch_timer: Gather KVM specific information in a structure Julien Grall
2016-04-12 5:43 ` Daniel Lezcano
2016-04-24 2:54 ` Shanker Donthineni
2016-04-11 15:32 ` [PATCH v6 02/10] clocksource: arm_arch_timer: Extend arch_timer_kvm_info to get the virtual IRQ Julien Grall
2016-04-12 5:44 ` Daniel Lezcano
2016-04-24 2:57 ` Shanker Donthineni
2016-04-11 15:32 ` Julien Grall [this message]
2016-04-24 2:58 ` [PATCH v6 03/10] irqchip/gic-v2: Gather ACPI specific data in a single structure Shanker Donthineni
2016-04-11 15:32 ` [PATCH v6 04/10] irqchip/gic-v2: Parse and export virtual GIC information Julien Grall
2016-04-13 9:50 ` Hanjun Guo
2016-04-24 3:00 ` Shanker Donthineni
2016-04-11 15:32 ` [PATCH v6 05/10] irqchip/gic-v3: Prefix all pr_* messages by "GICv3: " Julien Grall
2016-04-13 10:01 ` Hanjun Guo
2016-04-26 17:52 ` Julien Grall
2016-04-11 15:32 ` [PATCH v6 06/10] irqchip/gic-v3: Gather all ACPI specific data in a single structure Julien Grall
2016-04-24 3:02 ` Shanker Donthineni
2016-04-11 15:32 ` [PATCH v6 07/10] irqchip/gic-v3: Parse and export virtual GIC information Julien Grall
2016-04-24 3:05 ` Shanker Donthineni
2016-04-11 15:32 ` [PATCH v6 08/10] KVM: arm/arm64: arch_timer: Rely on the arch timer to parse the firmware tables Julien Grall
2016-04-24 3:06 ` Shanker Donthineni
2016-04-11 15:32 ` [PATCH v6 09/10] KVM: arm/arm64: vgic: Rely on the GIC driver " Julien Grall
2016-04-24 3:32 ` Shanker Donthineni
2016-04-11 15:33 ` [PATCH v6 10/10] clocksource: arm_arch_timer: Remove arch_timer_get_timecounter Julien Grall
2016-04-12 5:44 ` Daniel Lezcano
2016-04-12 12:15 ` Christoffer Dall
2016-04-12 12:49 ` Daniel Lezcano
2016-04-24 3:33 ` Shanker Donthineni
2016-04-28 13:13 ` [PATCH v6 00/10] arm64: Add support for KVM with ACPI Marc Zyngier
2016-05-02 12:54 ` Jason Cooper
2016-05-03 8:21 ` Christoffer Dall
2016-05-03 12:46 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460388780-914-4-git-send-email-julien.grall@arm.com \
--to=julien.grall@arm.com \
--cc=al.stone@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=fu.wei@linaro.org \
--cc=gg@slimlogic.co.uk \
--cc=hanjun.guo@linaro.org \
--cc=jason@lakedaemon.net \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=tglx@linutronix.de \
--cc=wei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®