From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964828AbcDLMMR (ORCPT ); Tue, 12 Apr 2016 08:12:17 -0400 Received: from mail-pf0-f172.google.com ([209.85.192.172]:34237 "EHLO mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932240AbcDLMMQ (ORCPT ); Tue, 12 Apr 2016 08:12:16 -0400 From: Sudip Mukherjee To: David Howells Cc: linux-kernel@vger.kernel.org, Sudip Mukherjee Subject: [PATCH] KEYS: fix memory leak Date: Tue, 12 Apr 2016 17:41:59 +0530 Message-Id: <1460463119-8409-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If the file read fails then we returned NULL as error but we missed freeing buf. Signed-off-by: Sudip Mukherjee --- scripts/insert-sys-cert.c | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/insert-sys-cert.c b/scripts/insert-sys-cert.c index 8902836..b98a0b1 100644 --- a/scripts/insert-sys-cert.c +++ b/scripts/insert-sys-cert.c @@ -251,6 +251,7 @@ static char *read_file(char *file_name, int *size) if (read(fd, buf, *size) != *size) { perror("File read failed"); close(fd); + free(buf); return NULL; } close(fd); -- 1.9.1