From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org,
rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com,
dvhart@linux.intel.com, fweisbec@gmail.com, oleg@redhat.com,
bobby.prani@gmail.com,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: [PATCH tip/core/rcu 06/16] rcu: Add funnel-locking tracing for expedited grace periods
Date: Tue, 12 Apr 2016 08:29:25 -0700 [thread overview]
Message-ID: <1460474975-24560-6-git-send-email-paulmck@linux.vnet.ibm.com> (raw)
In-Reply-To: <20160412152906.GA23395@linux.vnet.ibm.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
---
kernel/rcu/tree.c | 31 +++++++++++++++++++++++++++----
kernel/rcu/tree_plugin.h | 3 +++
2 files changed, 30 insertions(+), 4 deletions(-)
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 178575c01d09..79e9206a7b11 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -3584,10 +3584,18 @@ static bool sync_exp_work_done(struct rcu_state *rsp, struct rcu_node *rnp,
atomic_long_t *stat, unsigned long s)
{
if (rcu_exp_gp_seq_done(rsp, s)) {
- if (rnp)
+ if (rnp) {
mutex_unlock(&rnp->exp_funnel_mutex);
- else if (rdp)
+ trace_rcu_exp_funnel_lock(rsp->name, rnp->level,
+ rnp->grplo, rnp->grphi,
+ TPS("rel"));
+ } else if (rdp) {
mutex_unlock(&rdp->exp_funnel_mutex);
+ trace_rcu_exp_funnel_lock(rsp->name,
+ rdp->mynode->level + 1,
+ rdp->cpu, rdp->cpu,
+ TPS("rel"));
+ }
/* Ensure test happens before caller kfree(). */
smp_mb__before_atomic(); /* ^^^ */
atomic_long_inc(stat);
@@ -3619,6 +3627,9 @@ static struct rcu_node *exp_funnel_lock(struct rcu_state *rsp, unsigned long s)
if (sync_exp_work_done(rsp, rnp0, NULL,
&rdp->expedited_workdone0, s))
return NULL;
+ trace_rcu_exp_funnel_lock(rsp->name, rnp0->level,
+ rnp0->grplo, rnp0->grphi,
+ TPS("acq"));
return rnp0;
}
}
@@ -3634,16 +3645,28 @@ static struct rcu_node *exp_funnel_lock(struct rcu_state *rsp, unsigned long s)
if (sync_exp_work_done(rsp, NULL, NULL, &rdp->expedited_workdone1, s))
return NULL;
mutex_lock(&rdp->exp_funnel_mutex);
+ trace_rcu_exp_funnel_lock(rsp->name, rdp->mynode->level + 1,
+ rdp->cpu, rdp->cpu, TPS("acq"));
rnp0 = rdp->mynode;
for (; rnp0 != NULL; rnp0 = rnp0->parent) {
if (sync_exp_work_done(rsp, rnp1, rdp,
&rdp->expedited_workdone2, s))
return NULL;
mutex_lock(&rnp0->exp_funnel_mutex);
- if (rnp1)
+ trace_rcu_exp_funnel_lock(rsp->name, rnp0->level,
+ rnp0->grplo, rnp0->grphi, TPS("acq"));
+ if (rnp1) {
mutex_unlock(&rnp1->exp_funnel_mutex);
- else
+ trace_rcu_exp_funnel_lock(rsp->name, rnp1->level,
+ rnp1->grplo, rnp1->grphi,
+ TPS("rel"));
+ } else {
mutex_unlock(&rdp->exp_funnel_mutex);
+ trace_rcu_exp_funnel_lock(rsp->name,
+ rdp->mynode->level + 1,
+ rdp->cpu, rdp->cpu,
+ TPS("rel"));
+ }
rnp1 = rnp0;
}
if (sync_exp_work_done(rsp, rnp1, rdp,
diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
index a2ac2628ef8e..cd2dae43ff48 100644
--- a/kernel/rcu/tree_plugin.h
+++ b/kernel/rcu/tree_plugin.h
@@ -767,6 +767,9 @@ void synchronize_rcu_expedited(void)
/* Clean up and exit. */
rcu_exp_gp_seq_end(rsp);
mutex_unlock(&rnp_unlock->exp_funnel_mutex);
+ trace_rcu_exp_funnel_lock(rsp->name, rnp_unlock->level,
+ rnp_unlock->grplo, rnp_unlock->grphi,
+ TPS("rel"));
}
EXPORT_SYMBOL_GPL(synchronize_rcu_expedited);
--
2.5.2
next prev parent reply other threads:[~2016-04-12 15:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 15:29 [PATCH tip/core/rcu 0/16] Expedited grace-period changes for 4.7 Paul E. McKenney
2016-04-12 15:29 ` [PATCH tip/core/rcu 01/16] rcu: Make expedited RCU-sched grace period immediately detect idle Paul E. McKenney
2016-04-12 15:29 ` [PATCH tip/core/rcu 02/16] rcu: Make expedited RCU-preempt stall warnings count accurately Paul E. McKenney
2016-04-12 15:29 ` [PATCH tip/core/rcu 03/16] rcu: Make cond_resched_rcu_qs() supply RCU-sched expedited QS Paul E. McKenney
2016-04-12 15:29 ` [PATCH tip/core/rcu 04/16] rcu: Fix synchronize_rcu_expedited() header comment Paul E. McKenney
2016-04-12 15:29 ` [PATCH tip/core/rcu 05/16] rcu: Add event tracing definitions for expedited grace periods Paul E. McKenney
2016-04-12 15:29 ` Paul E. McKenney [this message]
2016-04-12 15:29 ` [PATCH tip/core/rcu 07/16] rcu: Add expedited-grace-period event tracing Paul E. McKenney
2016-04-12 15:29 ` [PATCH tip/core/rcu 08/16] rcu: Remove expedited GP funnel-lock bypass Paul E. McKenney
2016-04-12 15:29 ` [PATCH tip/core/rcu 09/16] rcu: Force boolean subscript for expedited stall warnings Paul E. McKenney
2016-04-12 15:29 ` [PATCH tip/core/rcu 10/16] rcu: Shorten expedited_workdone* to exp_workdone* Paul E. McKenney
2016-04-12 15:29 ` [PATCH tip/core/rcu 11/16] rcu: Enforce expedited-GP fairness via funnel wait queue Paul E. McKenney
2016-04-12 15:29 ` [PATCH tip/core/rcu 12/16] rcu: Add exp_funnel_lock() fastpath Paul E. McKenney
2016-04-12 15:29 ` [PATCH tip/core/rcu 13/16] rcu: Consolidate expedited GP code into rcu_exp_wait_wake() Paul E. McKenney
2016-04-12 15:29 ` [PATCH tip/core/rcu 14/16] rcu: Consolidate expedited GP tracing into rcu_exp_gp_seq_snap() Paul E. McKenney
2016-04-12 15:29 ` [PATCH tip/core/rcu 15/16] rcu: Consolidate expedited GP code into exp_funnel_lock() Paul E. McKenney
2016-04-12 15:29 ` [PATCH tip/core/rcu 16/16] rcu: Overlap wakeups with next expedited grace period Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460474975-24560-6-git-send-email-paulmck@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bobby.prani@gmail.com \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=dvhart@linux.intel.com \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=jiangshanlai@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome