From: Wang Nan <wangnan0@huawei.com>
To: <acme@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <pi3orama@163.com>,
Wang Nan <wangnan0@huawei.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
"Adrian Hunter" <adrian.hunter@intel.com>,
Jiri Olsa <jolsa@kernel.org>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
Namhyung Kim <namhyung@kernel.org>, Zefan Li <lizefan@huawei.com>,
He Kuang <hekuang@huawei.com>
Subject: [PATCH v2 0/6] perf tools: Use SIGUSR2 control data dumpping
Date: Thu, 14 Apr 2016 14:21:59 +0000 [thread overview]
Message-ID: <1460643725-167413-1-git-send-email-wangnan0@huawei.com> (raw)
This patch set is based on perf/core.
v1 -> v2: Fix a bug which triggers output switching without
'--switch-output' provided.
Patch 5/10 in v1 has a bug: with following cmdline:
# perf record -e intel_bts// --per-thread --snapshot -p 13588
Sending 'SIGUSR2' to perf triggers output switching, which us
undesirable. The reason is in signal handler perf doesn't consider if
user provided --switch-output explicitly.
With this patchset applied:
# /perf record --switch-output -e intel_bts// --per-thread --snapshot -p 13588 &
[1] 15116
# kill -s SIGUSR2 15116
# [ perf record: dump data: Woken up 5 times ]
[ perf record: Dump perf.data.2016041506170000 ]
# kill -s SIGUSR2 15116
# [ perf record: dump data: Woken up 3 times ]
[ perf record: Dump perf.data.2016041506170447 ]
# fg
/perf record --switch-output -e intel_bts// --per-thread --snapshot -p 13588
^C[ perf record: Woken up 3 times to write data ]
[ perf record: Dump perf.data.2016041506170785 ]
[ perf record: Captured and wrote 0.012 MB perf.data.<timestamp> ]
# ls -l ./perf.data*
-rw------- 1 root root 4212888 Apr 15 06:17 ./perf.data.2016041506170000
-rw------- 1 root root 4212704 Apr 15 06:17 ./perf.data.2016041506170447
-rw------- 1 root root 18368 Apr 15 06:17 ./perf.data.2016041506170785
The first 2 perf.data works fine. The final one has no samples.
And:
# rm ./perf.data*
# /perf record -e intel_bts// --per-thread --snapshot -p 13588 &
[1] 15396
# kill -s SIGUSR2 15396
# kill -s SIGUSR2 15396
# fg
/perf record -e intel_bts// --per-thread --snapshot -p 13588
^C[ perf record: Woken up 9 times to write data ]
[ perf record: Captured and wrote 8.012 MB perf.data ]
# ls -l ./perf.data*
-rw------- 1 root root 8417552 Apr 15 06:20 ./perf.data
(In v1, the second test trigger output switching incorrectly)
Patch 1-2/6 in this patchset makes switch output trigger similar to
auxtrace snapshot trigger. Patch 1/6 introduces a 'trigger' class for
them. It would be better to merge patch 1/6 with commit c0bdc1c ("perf
record: Turns auxtrace_snapshot_enable into 3 states"). However, Ingo
has collected that commit, so make it a separated patch.
Signed-off-by: Wang Nan <wangnan0@huawei.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Cc: He Kuang <hekuang@huawei.com>
Wang Nan (6):
perf tools: Extrace trigger class from auxtrace_snapshot
perf record: Split output into multiple files via '--switch-output'
perf record: Force enable --timestamp-filename when --switch-output is
provided
perf record: Disable buildid cache options by default in switch output
mode
perf record: Re-synthesize tracking events after output switching
perf record: Generate tracking events for process forked by perf
tools/perf/builtin-record.c | 147 +++++++++++++++++++++++++++++++-------------
tools/perf/util/util.h | 60 ++++++++++++++++++
2 files changed, 163 insertions(+), 44 deletions(-)
--
1.8.3.4
next reply other threads:[~2016-04-14 14:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 14:21 Wang Nan [this message]
2016-04-14 14:22 ` [PATCH v2 1/6] perf tools: Extrace trigger class from auxtrace_snapshot Wang Nan
2016-04-14 14:22 ` [PATCH v2 2/6] perf record: Split output into multiple files via '--switch-output' Wang Nan
2016-04-14 23:59 ` Arnaldo Carvalho de Melo
2016-04-14 14:22 ` [PATCH v2 3/6] perf record: Force enable --timestamp-filename when --switch-output is provided Wang Nan
2016-04-14 14:22 ` [PATCH v2 4/6] perf record: Disable buildid cache options by default in switch output mode Wang Nan
2016-04-14 14:22 ` [PATCH v2 5/6] perf record: Re-synthesize tracking events after output switching Wang Nan
2016-04-14 14:22 ` [PATCH v2 6/6] perf record: Generate tracking events for process forked by perf Wang Nan
2016-04-15 0:19 ` [PATCH v2 0/6] perf tools: Use SIGUSR2 control data dumpping Arnaldo Carvalho de Melo
2016-04-15 13:14 ` Adrian Hunter
2016-04-15 13:35 ` Arnaldo Carvalho de Melo
2016-04-15 13:41 ` Wangnan (F)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460643725-167413-1-git-send-email-wangnan0@huawei.com \
--to=wangnan0@huawei.com \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mhiramat@kernel.org \
--cc=namhyung@kernel.org \
--cc=pi3orama@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®