From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932713AbcDNPTM (ORCPT ); Thu, 14 Apr 2016 11:19:12 -0400 Received: from mail-pf0-f180.google.com ([209.85.192.180]:36061 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756474AbcDNPTJ (ORCPT ); Thu, 14 Apr 2016 11:19:09 -0400 From: Sudip Mukherjee To: Johnny Kim , Austin Shin , Chris Park , Tony Cho , Glen Lee , Leo Kim , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, Sudip Mukherjee Subject: [PATCH 1/2] staging: wilc1000: fix double unlock Date: Thu, 14 Apr 2016 20:48:48 +0530 Message-Id: <1460647129-22740-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The semaphore was being released twice, once at the beginning of the thread and then again when the thread is about to close. The semaphore is acquired immediately after creating the thread so we should be releasing it when the thread ends. Signed-off-by: Sudip Mukherjee --- drivers/staging/wilc1000/linux_wlan.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c index a858552..5643a3d 100644 --- a/drivers/staging/wilc1000/linux_wlan.c +++ b/drivers/staging/wilc1000/linux_wlan.c @@ -313,7 +313,6 @@ static int linux_wlan_txq_task(void *vp) vif = netdev_priv(dev); wl = vif->wilc; - up(&wl->txq_thread_started); while (1) { down(&wl->txq_event); -- 1.9.1