From: Denys Vlasenko <dvlasenk@redhat.com>
To: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>,
David Howells <dhowells@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] nfs: make nfs_initialise_sb() static and deinline it
Date: Fri, 15 Apr 2016 18:02:19 +0200 [thread overview]
Message-ID: <1460736139-482-1-git-send-email-dvlasenk@redhat.com> (raw)
nfs_initialise_sb() is only used in fs/nfs/super.c, no need to be global.
superblock init is not a performance-critical operation, no need to inline.
It compiles to 220 bytes and has two callsites.
text data bss dec hex filename
95903714 20860256 35991552 152755522 91add42 vmlinux_before
95903330 20860256 35991552 152755138 91adbc2 vmlinux
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: Trond Myklebust <trond.myklebust@primarydata.com>
CC: David Howells <dhowells@redhat.com>
CC: Al Viro <viro@zeniv.linux.org.uk>
CC: linux-fsdevel@vger.kernel.org
CC: linux-kernel@vger.kernel.org
---
fs/nfs/internal.h | 1 -
fs/nfs/super.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h
index f1d1d2c..ae235bb 100644
--- a/fs/nfs/internal.h
+++ b/fs/nfs/internal.h
@@ -393,7 +393,6 @@ extern struct file_system_type nfs4_referral_fs_type;
bool nfs_auth_info_match(const struct nfs_auth_info *, rpc_authflavor_t);
struct dentry *nfs_try_mount(int, const char *, struct nfs_mount_info *,
struct nfs_subversion *);
-void nfs_initialise_sb(struct super_block *);
int nfs_set_sb_security(struct super_block *, struct dentry *, struct nfs_mount_info *);
int nfs_clone_sb_security(struct super_block *, struct dentry *, struct nfs_mount_info *);
struct dentry *nfs_fs_mount_common(struct nfs_server *, int, const char *,
diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index f126828..215277b 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -2281,7 +2281,7 @@ EXPORT_SYMBOL_GPL(nfs_remount);
/*
* Initialise the common bits of the superblock
*/
-inline void nfs_initialise_sb(struct super_block *sb)
+static void nfs_initialise_sb(struct super_block *sb)
{
struct nfs_server *server = NFS_SB(sb);
--
1.8.1.4
reply other threads:[~2016-04-15 16:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460736139-482-1-git-send-email-dvlasenk@redhat.com \
--to=dvlasenk@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®