From: Davidlohr Bueso <dave@stgolabs.net>
To: bart.vanassche@sandisk.com
Cc: dave@stgolabs.net, linux-kernel@vger.kernel.org,
Davidlohr Bueso <dbueso@suse.de>
Subject: [PATCH] irq_poll: Remove redundant barrier when using clear_bit_unlock()
Date: Sat, 16 Apr 2016 10:55:36 -0700 [thread overview]
Message-ID: <1460829336-6146-1-git-send-email-dave@stgolabs.net> (raw)
... as the call obviously already implies unlock/RC semantics,
therefore lets get rid of the superfluous smp_mb calls.
Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
---
lib/irq_poll.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/irq_poll.c b/lib/irq_poll.c
index 836f7db4e548..2a6ae2720ccb 100644
--- a/lib/irq_poll.c
+++ b/lib/irq_poll.c
@@ -50,7 +50,6 @@ EXPORT_SYMBOL(irq_poll_sched);
static void __irq_poll_complete(struct irq_poll *iop)
{
list_del(&iop->list);
- smp_mb__before_atomic();
clear_bit_unlock(IRQ_POLL_F_SCHED, &iop->state);
}
@@ -161,7 +160,6 @@ EXPORT_SYMBOL(irq_poll_disable);
void irq_poll_enable(struct irq_poll *iop)
{
BUG_ON(!test_bit(IRQ_POLL_F_SCHED, &iop->state));
- smp_mb__before_atomic();
clear_bit_unlock(IRQ_POLL_F_SCHED, &iop->state);
}
EXPORT_SYMBOL(irq_poll_enable);
--
2.8.1
next reply other threads:[~2016-04-16 17:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-16 17:55 Davidlohr Bueso [this message]
2016-04-19 12:24 ` Bart Van Assche
2016-04-20 4:23 ` Davidlohr Bueso
2016-04-25 22:22 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460829336-6146-1-git-send-email-dave@stgolabs.net \
--to=dave@stgolabs.net \
--cc=bart.vanassche@sandisk.com \
--cc=dbueso@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®