From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752018AbcDPUQ4 (ORCPT ); Sat, 16 Apr 2016 16:16:56 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:50883 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751508AbcDPUQz (ORCPT ); Sat, 16 Apr 2016 16:16:55 -0400 From: Arnd Bergmann To: Bjorn Helgaas Cc: Arnd Bergmann , Rob Herring , Geert Uytterhoeven , Simon Horman , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] PCI: rcar: select PCI_MSI_IRQ_DOMAIN Date: Sat, 16 Apr 2016 22:15:46 +0200 Message-Id: <1460837798-1239513-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:7ORVKbRjB8/axFvig0LuL14uEPMBuiVNikxWU7PleGmR5inJmHL Hd5SRuAk7wHSt0NZdlPlStaSW487MzLJ9oMRKCs323M/Z8J/zAGZsti2hqEgnG7atfkbyUR vkdxPom9K92ENbFsX2//zJGZexdvhQO6fRLQnUoiCYnaIXncreQQIQZz/9yCq0MDzIpq1iz 7azSAgGi1t8n8R8OF9rkA== X-UI-Out-Filterresults: notjunk:1;V01:K0:kRrkVO4Drq4=:e4tHV4BwfWAinq31tHmrXb kBwFqd4RzgnQgSkDnZIyEHoCJj8SH2srtnT0lBEfetJdV4a8b9NhPtBZK9j8KcDoDuDRNIf+G 2JlX2zxSarWiiDh+ocRPhYCGmPXCSSMcenrIRSmtMibQJjY8qOw2DioJJD8WCq2dy/M3nhId3 KCl8crjY0K4SkINHFxgl3F/zUNwdwfYFZKqTY0T16RzXNZPbAEmojx9gQfCc5Jn8FGXYtlApt OF5n10RN/l9HwuRCFXPpmto85QyzmbZoQIlTiTtkEIbnIbzv6F+wNJWACfi72VYGxUnWitWsS M8svIhVmE+VhrxpB01vMVhUrFkaFGvSAgD5cKNca5hQ3tZP0uO2nNtXFKD1veh+Q4CH713GQG Y/hY8/m9r8RQMXJjuGjYCQyPyFgtwojQNotqTGrCVf3SdCQnUjso8Y0gZZQF8dKlpvcj+vMvB AbVb+/Y8wI4yKsoAfxZLVdzYUmlNuKd7diK7NKVYKQnwroZXEEajGDp/ojAwlEO2QpM0UZL/u AD4dn0eOjM14PwQYYbTj9P1pAPe8e28cez6ZHyrd9gEtWuhBqgvqict2PY3z2lLphwmRDFOTn MTHXN3hlePUSYr8su/1ZbBaFt3L8KnFSfpNT7do5F4lYJGNrU0HawFfArJg4NSE2Djn9aRTTR a2gS8iGNZ7a1me1yppHjVvbC4MkNsCW1J1ZrJpakJglTEd7Oj+VsLZseBXT/S8s77cGc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The R-CAR PCIe driver requires the use of irq domains for its MSI code: drivers/pci/host/pcie-rcar.c: In function 'rcar_pcie_msi_irq': drivers/pci/host/pcie-rcar.c:635:9: error: implicit declaration of function 'irq_find_mapping' [-Werror=implicit-function-declaration] drivers/pci/host/pcie-rcar.c: In function 'rcar_msi_setup_irq': drivers/pci/host/pcie-rcar.c:666:8: error: implicit declaration of function 'irq_create_mapping' [-Werror=implicit-function-declaration] drivers/pci/host/pcie-rcar.c: In function 'rcar_pcie_enable_msi': drivers/pci/host/pcie-rcar.c:725:16: error: implicit declaration of function 'irq_domain_add_linear' [-Werror=implicit-function-declaration] drivers/pci/host/pcie-rcar.c:725:14: error: assignment makes pointer from integer without a cast [-Werror=int-conversion] msi->domain = irq_domain_add_linear(pcie->dev->of_node, INT_PCI_MSI_NR, ^ drivers/pci/host/pcie-rcar.c:762:2: error: implicit declaration of function 'irq_domain_remove' [-Werror=implicit-function-declaration] This ensures that the feature is always enabled by adding a Kconfig select statement. This is not consistent with what the other drivers do at the moment, but I have another patch that changes them to do it like this one, which is more logical. Signed-off-by: Arnd Bergmann --- drivers/pci/host/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig index 169c545bf70a..6d642aa390b0 100644 --- a/drivers/pci/host/Kconfig +++ b/drivers/pci/host/Kconfig @@ -72,6 +72,8 @@ config PCI_RCAR_GEN2 config PCI_RCAR_GEN2_PCIE bool "Renesas R-Car PCIe controller" depends on ARCH_RENESAS || (ARM && COMPILE_TEST) + select PCI_MSI + select PCI_MSI_IRQ_DOMAIN help Say Y here if you want PCIe controller support on R-Car Gen2 SoCs. -- 2.7.0