mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafał Miłecki" <zajec5@gmail.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: linux-mtd@lists.infradead.org, "Rafał Miłecki" <zajec5@gmail.com>,
	"Wenyou Yang" <wenyou.yang@atmel.com>,
	"Josh Wu" <rainyfeeling@outlook.com>,
	"Richard Weinberger" <richard@nod.at>,
	"David Woodhouse" <dwmw2@infradead.org>,
	"Brian Norris" <computersforpeace@gmail.com>,
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH V2 03/11] mtd: nand: atmel: set ECC algorithm explicitly
Date: Sun, 17 Apr 2016 19:11:36 +0200	[thread overview]
Message-ID: <1460913104-27388-4-git-send-email-zajec5@gmail.com> (raw)
In-Reply-To: <1460913104-27388-1-git-send-email-zajec5@gmail.com>

This is part of process deprecating NAND_ECC_SOFT_BCH (and switching to
enum nand_ecc_algo).

Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
V2: Set algo to Hamming based on mode being SOFT. Add a comment how to
    modify it if we ever need to.
---
 drivers/mtd/nand/atmel_nand.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index eec8ca7..efc8ea2 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/nand/atmel_nand.c
@@ -1212,6 +1212,7 @@ static int atmel_pmecc_nand_init_params(struct platform_device *pdev,
 		dev_warn(host->dev,
 			"Can't get I/O resource regs for PMECC controller, rolling back on software ECC\n");
 		nand_chip->ecc.mode = NAND_ECC_SOFT;
+		nand_chip->ecc.algo = NAND_ECC_HAMMING;
 		return 0;
 	}
 
@@ -1295,6 +1296,7 @@ static int atmel_pmecc_nand_init_params(struct platform_device *pdev,
 		/* page size not handled by HW ECC */
 		/* switching back to soft ECC */
 		nand_chip->ecc.mode = NAND_ECC_SOFT;
+		nand_chip->ecc.algo = NAND_ECC_HAMMING;
 		return 0;
 	}
 
@@ -1613,6 +1615,7 @@ static int atmel_of_init_port(struct atmel_nand_host *host,
 	 * even if the nand-ecc-mode property is not defined.
 	 */
 	host->nand_chip.ecc.mode = NAND_ECC_SOFT;
+	host->nand_chip.ecc.algo = NAND_ECC_HAMMING;
 
 	return 0;
 }
@@ -1629,6 +1632,7 @@ static int atmel_hw_nand_init_params(struct platform_device *pdev,
 		dev_err(host->dev,
 			"Can't get I/O resource regs, use software ECC\n");
 		nand_chip->ecc.mode = NAND_ECC_SOFT;
+		nand_chip->ecc.algo = NAND_ECC_HAMMING;
 		return 0;
 	}
 
@@ -1661,6 +1665,7 @@ static int atmel_hw_nand_init_params(struct platform_device *pdev,
 		/* page size not handled by HW ECC */
 		/* switching back to soft ECC */
 		nand_chip->ecc.mode = NAND_ECC_SOFT;
+		nand_chip->ecc.algo = NAND_ECC_HAMMING;
 		return 0;
 	}
 
@@ -2160,6 +2165,14 @@ static int atmel_nand_probe(struct platform_device *pdev)
 		       sizeof(struct atmel_nand_data));
 		nand_chip->ecc.mode = host->board.ecc_mode;
 
+		/*
+		 * When using software ECC every supported avr32 board means
+		 * Hamming algorithm. If that ever changes we'll need to add
+		 * ecc_algo field to the struct atmel_nand_data.
+		 */
+		if (nand_chip->ecc.mode == NAND_ECC_SOFT)
+			nand_chip->ecc.algo = NAND_ECC_HAMMING;
+
 		/* 16-bit bus width */
 		if (host->board.bus_width_16)
 			nand_chip->options |= NAND_BUSWIDTH_16;
-- 
1.8.4.5

  parent reply	other threads:[~2016-04-17 17:12 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1460750052-16285-1-git-send-email-zajec5@gmail.com>
2016-04-15 19:54 ` [PATCH 01/12] mtd: nand: bf5xx: " Rafał Miłecki
2016-04-15 19:54 ` [PATCH 02/12] mtd: nand: davinci: " Rafał Miłecki
2016-04-15 19:54 ` [PATCH 03/12] avr32: set Atmel NAND " Rafał Miłecki
2016-04-16  7:38   ` Boris Brezillon
2016-04-16 12:58   ` Hans-Christian Noren Egtvedt
2016-04-15 19:54 ` [PATCH 04/12] mtd: nand: atmel: set " Rafał Miłecki
2016-04-16  7:40   ` Boris Brezillon
2016-04-15 19:54 ` [PATCH 05/12] CRIS v32: nand: " Rafał Miłecki
2016-04-15 19:54 ` [PATCH 06/12] staging: mt29f_spinand: " Rafał Miłecki
2016-04-15 19:54 ` [PATCH 07/12] mtd: nand: set ECC algorithm to Hamming on fallback Rafał Miłecki
2016-04-15 19:54 ` [PATCH 08/12] mtd: nand: hisi504: set ECC algorithm based on DT info Rafał Miłecki
2016-04-16  7:48   ` Boris Brezillon
2016-04-15 19:54 ` [PATCH 09/12] mtd: nand: fsmc: validate ECC setup by checking algorithm directly Rafał Miłecki
2016-04-15 20:23   ` Joe Perches
2016-04-15 20:24     ` Joe Perches
2016-04-15 20:43       ` Rafał Miłecki
2016-04-15 19:54 ` [PATCH 10/12] mtd: nand: read ECC algorithm from the new field Rafał Miłecki
2016-04-16  7:58   ` Boris Brezillon
2016-04-16  8:11     ` Boris Brezillon
2016-04-17 16:27     ` Rafał Miłecki
2016-04-17 16:50       ` Boris Brezillon
2016-04-17 16:57         ` Boris Brezillon
2016-04-17 16:57         ` Rafał Miłecki
2016-04-15 19:54 ` [PATCH 11/12] of: mtd: drop support for NAND_ECC_SOFT_BCH as "soft_bch" mapping Rafał Miłecki
2016-04-16  8:00   ` Boris Brezillon
2016-04-16  8:01     ` Boris Brezillon
2016-04-15 19:54 ` [PATCH 12/12] mtd: mtd: drop NAND_ECC_SOFT_BCH enum value Rafał Miłecki
2016-04-17 17:05   ` Boris Brezillon
2016-04-17 17:10     ` Rafał Miłecki
2016-04-17 19:01       ` Boris Brezillon
     [not found] ` <1460913104-27388-1-git-send-email-zajec5@gmail.com>
2016-04-17 17:11   ` [PATCH V2 01/11] mtd: nand: bf5xx: set ECC algorithm explicitly Rafał Miłecki
2016-04-17 17:11   ` [PATCH V2 02/11] mtd: nand: davinci: " Rafał Miłecki
2016-04-17 17:11   ` Rafał Miłecki [this message]
2016-04-17 17:11   ` [PATCH V2 04/11] CRIS v32: nand: " Rafał Miłecki
2016-04-17 17:11   ` [PATCH V2 05/11] staging: mt29f_spinand: " Rafał Miłecki
2016-04-17 17:11   ` [PATCH V2 06/11] mtd: nand: set ECC algorithm to Hamming on fallback Rafał Miłecki
2016-04-17 17:11   ` [PATCH V2 07/11] mtd: nand: hisi504: set ECC algorithm based on DT info Rafał Miłecki
2016-04-17 17:11   ` [PATCH V2 08/11] mtd: nand: fsmc: validate ECC setup by checking algorithm directly Rafał Miłecki
2016-04-17 17:11   ` [PATCH V2 09/11] mtd: nand: read ECC algorithm from the new field Rafał Miłecki
2016-04-17 18:59     ` Boris Brezillon
2016-04-17 17:11   ` [PATCH V2 10/11] of: mtd: drop support for NAND_ECC_SOFT_BCH as "soft_bch" mapping Rafał Miłecki
2016-04-17 17:11   ` [PATCH V2 11/11] mtd: mtd: drop NAND_ECC_SOFT_BCH enum value Rafał Miłecki
     [not found]   ` <1460926387-9563-1-git-send-email-zajec5@gmail.com>
2016-04-17 20:52     ` [PATCH V3 01/11] mtd: nand: bf5xx: set ECC algorithm explicitly Rafał Miłecki
2016-04-17 20:52     ` [PATCH V3 02/11] mtd: nand: davinci: " Rafał Miłecki
2016-04-17 20:52     ` [PATCH V3 03/11] mtd: nand: atmel: " Rafał Miłecki
2016-04-17 20:53     ` [PATCH V3 04/11] CRIS v32: nand: " Rafał Miłecki
2016-04-21 20:18       ` Boris Brezillon
2016-04-21 20:44       ` Mikael Starvik
2016-04-22  7:26       ` Jesper Nilsson
2016-04-17 20:53     ` [PATCH V3 05/11] staging: mt29f_spinand: " Rafał Miłecki
2016-04-21 20:20       ` Boris Brezillon
2016-04-22  2:32         ` Greg Kroah-Hartman
2016-04-17 20:53     ` [PATCH V3 06/11] mtd: nand: set ECC algorithm to Hamming on fallback Rafał Miłecki
2016-04-17 20:53     ` [PATCH V3 07/11] mtd: nand: hisi504: set ECC algorithm based on DT info Rafał Miłecki
2016-04-17 20:53     ` [PATCH V3 08/11] mtd: nand: fsmc: validate ECC setup by checking algorithm directly Rafał Miłecki
2016-04-17 20:53     ` [PATCH V3 09/11] mtd: nand: read ECC algorithm from the new field Rafał Miłecki
2016-04-17 20:53     ` [PATCH V3 10/11] of: mtd: drop support for NAND_ECC_SOFT_BCH as "soft_bch" mapping Rafał Miłecki
2016-04-17 20:53     ` [PATCH V3 11/11] mtd: mtd: drop NAND_ECC_SOFT_BCH enum value Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1460913104-27388-4-git-send-email-zajec5@gmail.com \
    --to=zajec5@gmail.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=rainyfeeling@outlook.com \
    --cc=richard@nod.at \
    --cc=wenyou.yang@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®