From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751694AbcDRAfx (ORCPT ); Sun, 17 Apr 2016 20:35:53 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:42018 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751531AbcDRAfv (ORCPT ); Sun, 17 Apr 2016 20:35:51 -0400 X-Sasl-enc: op9QoE+33pT5rpTsdeyZKO8do93afvGbP8c5Pep8TNV8 1460939744 From: Tobin C Harding To: gregkh@linuxfoundation.org Cc: arve@android.com, riandrews@android.com, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Tobin C Harding Subject: [PATCH v2 3/4] drivers: staging: remove comparison to NULL Date: Mon, 18 Apr 2016 10:35:30 +1000 Message-Id: <1460939731-7746-4-git-send-email-me@tobin.cc> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1460939731-7746-1-git-send-email-me@tobin.cc> References: <1460939731-7746-1-git-send-email-me@tobin.cc> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org drivers/staging/android/ion/ion.c checkpatch produces 'Comparison to NULL could be written ...' checks. This patch replaces comparison to NULL with !var as suggested by checkpatch. Signed-off-by: Tobin C Harding --- drivers/staging/android/ion/ion.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 4e02209..234848f 100644 --- a/drivers/staging/android/ion/ion.c +++ b/drivers/staging/android/ion/ion.c @@ -209,7 +209,7 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap, buffer->size = len; table = heap->ops->map_dma(heap, buffer); - if (WARN_ONCE(table == NULL, + if (WARN_ONCE(!table, "heap->ops->map_dma should return ERR_PTR on error")) table = ERR_PTR(-EINVAL); if (IS_ERR(table)) { @@ -522,7 +522,7 @@ struct ion_handle *ion_alloc(struct ion_client *client, size_t len, } up_read(&dev->lock); - if (buffer == NULL) + if (!buffer) return ERR_PTR(-ENODEV); if (IS_ERR(buffer)) @@ -612,7 +612,7 @@ static void *ion_buffer_kmap_get(struct ion_buffer *buffer) return buffer->vaddr; } vaddr = buffer->heap->ops->map_kernel(buffer->heap, buffer); - if (WARN_ONCE(vaddr == NULL, + if (WARN_ONCE(!vaddr, "heap->ops->map_kernel should return ERR_PTR on error")) return ERR_PTR(-EINVAL); if (IS_ERR(vaddr)) -- 2.7.4