From: Jens Axboe <axboe@fb.com>
To: <linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
<linux-block@vger.kernel.org>
Cc: <jack@suse.cz>, <dchinner@redhat.com>, Jens Axboe <axboe@fb.com>
Subject: [PATCH 5/8] writeback: increment page wait count when waiting
Date: Sun, 17 Apr 2016 23:24:44 -0500 [thread overview]
Message-ID: <1460953487-3430-6-git-send-email-axboe@fb.com> (raw)
In-Reply-To: <1460953487-3430-1-git-send-email-axboe@fb.com>
If we end up waiting on a page that is dirty or marked writeback,
then increment the corresponding bdi_writeback counter.
Signed-off-by: Jens Axboe <axboe@fb.com>
---
mm/filemap.c | 42 +++++++++++++++++++++++++++++++++++++++---
1 file changed, 39 insertions(+), 3 deletions(-)
diff --git a/mm/filemap.c b/mm/filemap.c
index f2479af09da9..a8854a083b71 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -764,37 +764,73 @@ wait_queue_head_t *page_waitqueue(struct page *page)
}
EXPORT_SYMBOL(page_waitqueue);
+static bool inc_dirty_wait(struct page *page)
+{
+ if (!page->mapping || !PageDirty(page) || !PageWriteback(page))
+ return false;
+ else {
+ struct bdi_writeback *wb = inode_to_wb(page->mapping->host);
+
+ atomic_inc(&wb->dirty_sleeping);
+ return true;
+ }
+}
+
+static void dec_dirty_wait(struct page *page)
+{
+ struct bdi_writeback *wb = inode_to_wb(page->mapping->host);
+
+ atomic_dec(&wb->dirty_sleeping);
+}
+
void wait_on_page_bit(struct page *page, int bit_nr)
{
DEFINE_WAIT_BIT(wait, &page->flags, bit_nr);
- if (test_bit(bit_nr, &page->flags))
+ if (test_bit(bit_nr, &page->flags)) {
+ bool did_inc = inc_dirty_wait(page);
__wait_on_bit(page_waitqueue(page), &wait, bit_wait_io,
TASK_UNINTERRUPTIBLE);
+ if (did_inc)
+ dec_dirty_wait(page);
+ }
}
EXPORT_SYMBOL(wait_on_page_bit);
int wait_on_page_bit_killable(struct page *page, int bit_nr)
{
DEFINE_WAIT_BIT(wait, &page->flags, bit_nr);
+ bool did_inc;
+ int ret;
if (!test_bit(bit_nr, &page->flags))
return 0;
- return __wait_on_bit(page_waitqueue(page), &wait,
+ did_inc = inc_dirty_wait(page);
+ ret = __wait_on_bit(page_waitqueue(page), &wait,
bit_wait_io, TASK_KILLABLE);
+ if (did_inc)
+ dec_dirty_wait(page);
+ return ret;
}
int wait_on_page_bit_killable_timeout(struct page *page,
int bit_nr, unsigned long timeout)
{
DEFINE_WAIT_BIT(wait, &page->flags, bit_nr);
+ bool did_inc;
+ int ret;
wait.key.timeout = jiffies + timeout;
if (!test_bit(bit_nr, &page->flags))
return 0;
- return __wait_on_bit(page_waitqueue(page), &wait,
+
+ did_inc = inc_dirty_wait(page);
+ ret = __wait_on_bit(page_waitqueue(page), &wait,
bit_wait_io_timeout, TASK_KILLABLE);
+ if (did_inc)
+ dec_dirty_wait(page);
+ return ret;
}
EXPORT_SYMBOL_GPL(wait_on_page_bit_killable_timeout);
--
2.8.0.rc4.6.g7e4ba36
next prev parent reply other threads:[~2016-04-18 4:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 4:24 [PATCHSET v4 0/8] Make background writeback not suck Jens Axboe
2016-04-18 4:24 ` [PATCH 1/8] block: add WRITE_BG Jens Axboe
2016-04-18 4:24 ` [PATCH 2/8] writeback: add wbc_to_write_cmd() Jens Axboe
2016-04-18 15:12 ` Jan Kara
2016-04-18 20:18 ` Jens Axboe
2016-04-18 4:24 ` [PATCH 3/8] writeback: use WRITE_BG for kupdate and background writeback Jens Axboe
2016-04-18 4:24 ` [PATCH 4/8] writeback: track if we're sleeping on progress in balance_dirty_pages() Jens Axboe
2016-04-18 4:24 ` Jens Axboe [this message]
2016-04-18 4:24 ` [PATCH 6/8] block: add code to track actual device queue depth Jens Axboe
2016-04-18 4:24 ` [PATCH 7/8] block: add scalable completion tracking of requests Jens Axboe
2016-04-18 4:24 ` [PATCH 8/8] writeback: throttle buffered writeback Jens Axboe
2016-04-23 8:21 ` xiakaixu
2016-04-23 21:37 ` Jens Axboe
2016-04-25 11:41 ` xiakaixu
2016-04-25 14:37 ` Jens Axboe
2016-04-26 7:04 ` [PATCHSET v4 0/8] Make background writeback not suck Sedat Dilek
2016-04-26 15:07 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460953487-3430-6-git-send-email-axboe@fb.com \
--to=axboe@fb.com \
--cc=dchinner@redhat.com \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®