From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751868AbcDRIrm (ORCPT ); Mon, 18 Apr 2016 04:47:42 -0400 Received: from smtprelay0139.hostedemail.com ([216.40.44.139]:43925 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751335AbcDRIrl (ORCPT ); Mon, 18 Apr 2016 04:47:41 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:152:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1981:2194:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:5007:9108:10004:10400:10848:11026:11232:11473:11657:11658:11783:11914:12043:12296:12517:12519:12663:12679:12740:13069:13095:13311:13357:13894:14659:14721:21080:30054:30064:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: scale18_25aaeff270e2c X-Filterd-Recvd-Size: 2366 Message-ID: <1460969256.19090.110.camel@perches.com> Subject: Re: [PATCH 2/2] Staging: Lustre: Fixed coding style issues From: Joe Perches To: "Drokin, Oleg" , Panos Vlachos Cc: "" , "" , "Dilger, Andreas" Date: Mon, 18 Apr 2016 01:47:36 -0700 In-Reply-To: References: <1460902313-5327-1-git-send-email-panosvlchs@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-04-17 at 21:35 +0000, Drokin, Oleg wrote: > On Apr 17, 2016, at 10:11 AM, Panos Vlachos wrote: > > Fixed one coding style issue in the > > file router_proc.c (Lustre staging driver) > Perhaps it's best to reference what the issue is. > I.e. "Fix too long line in …" > and then in the actual message add that you just split it? [] > > diff --git a/drivers/staging/lustre/lnet/lnet/router_proc.c b/drivers/staging/lustre/lnet/lnet/router_proc.c [] > > @@ -32,7 +32,8 @@ > >  */ > > #define LNET_PROC_CPT_BITS (LNET_CPT_BITS + 1) > > /* change version, 16 bits or 8 bits */ > > -#define LNET_PROC_VER_BITS max_t(size_t, min_t(size_t, LNET_LOFFT_BITS, 64) / 4, 8) > > +#define LNET_PROC_VER_BITS \ > > +max_t(size_t, min_t(size_t, LNET_LOFFT_BITS, 64) / 4, 8) > Hm, I am not sure this is an improvement, you might want to at least place a tab at the start of this > second line, so that indentation helps us better see it's a continuation of the previous one. Given: #define LNET_LOFFT_BITS          (sizeof(loff_t) * 8) and: include/linux/types.h:typedef __kernel_loff_t           loff_t; include/uapi/asm-generic/posix_types.h:typedef long long        __kernel_loff_t; and this isn't going to change any time soon, maybe this #define isn't particularly useful and #define LNET_PROC_VER_BITS 16 is sufficient.