From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753876AbcDTJQ4 (ORCPT ); Wed, 20 Apr 2016 05:16:56 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:56470 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753036AbcDTJQx (ORCPT ); Wed, 20 Apr 2016 05:16:53 -0400 From: Mark Brown To: Greg Kroah-Hartman Cc: Srinivas Kandagatla , Andrew Lunn , linux-kernel@vger.kernel.org, Mark Brown Date: Wed, 20 Apr 2016 10:16:36 +0100 Message-Id: <1461143796-30669-2-git-send-email-broonie@kernel.org> X-Mailer: git-send-email 2.8.0.rc3 In-Reply-To: <1461143796-30669-1-git-send-email-broonie@kernel.org> References: <1461143796-30669-1-git-send-email-broonie@kernel.org> X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: [PATCH 2/2] eeprom: 93xx46: Fix SPI device leak X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The 93xx46 driver is using spi_dev_get() apparently just to take a copy of the SPI device used to instantiate it but never calls spi_dev_put() to free it. Since the device is guaranteed to exist between probe() and remove() there should be no need for the driver to take an extra reference to it so fix the leak by just using a straight assignment. Signed-off-by: Mark Brown --- drivers/misc/eeprom/eeprom_93xx46.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/eeprom/eeprom_93xx46.c b/drivers/misc/eeprom/eeprom_93xx46.c index 426fe2fd5238..d971ae9eefde 100644 --- a/drivers/misc/eeprom/eeprom_93xx46.c +++ b/drivers/misc/eeprom/eeprom_93xx46.c @@ -511,7 +511,7 @@ static int eeprom_93xx46_probe(struct spi_device *spi) mutex_init(&edev->lock); - edev->spi = spi_dev_get(spi); + edev->spi = spi; edev->pdata = pd; edev->size = 128; -- 2.8.0.rc3