From: Joe Perches <joe@perches.com>
To: Gustavo Padovan <gustavo@padovan.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
dri-devel@lists.freedesktop.org,
"Daniel Stone" <daniels@collabora.com>,
"Arve Hjønnevåg" <arve@android.com>,
"Riley Andrews" <riandrews@android.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Rob Clark" <robdclark@gmail.com>,
"Greg Hackmann" <ghackmann@google.com>,
"John Harrison" <John.C.Harrison@Intel.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Gustavo Padovan" <gustavo.padovan@collabora.co.uk>,
"Andrew Morton" <akpm@linux-foundation.org>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel.vetter@Intel.com>
Subject: Re: [PATCH 2/3] kernel.h: add u64_to_user_ptr()
Date: Wed, 20 Apr 2016 18:46:16 -0700 [thread overview]
Message-ID: <1461203176.1918.3.camel@perches.com> (raw)
In-Reply-To: <1461179926-20542-2-git-send-email-gustavo@padovan.org>
On Wed, 2016-04-20 at 16:18 -0300, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>
> This function had copies in 3 different files. Unify them in kernel.h.
[]
> diff --git a/include/linux/kernel.h b/include/linux/kernel.h
[]
> @@ -53,6 +53,12 @@
>
> #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
>
> +static inline void __user *u64_to_user_ptr(u64 address)
> +{
> + typecheck(u64, address);
> + return (void __user *)(uintptr_t)address;
> +}
> +
This won't work because by the time address is checked
address is already u64
This would need to be something like
#define u64_to_user_ptr(x) \
({ \
typecheck(u64, x); \
u64_to_user_ptr(x); \
})
next prev parent reply other threads:[~2016-04-21 1:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 19:18 [PATCH 1/3] staging/android: remove redundant comments on sync_merge_data Gustavo Padovan
2016-04-20 19:18 ` [PATCH 2/3] kernel.h: add u64_to_user_ptr() Gustavo Padovan
2016-04-21 1:46 ` Joe Perches [this message]
2016-04-21 13:36 ` Gustavo Padovan
2016-04-20 19:18 ` [PATCH 3/3] staging/android: refactor SYNC IOCTLs Gustavo Padovan
2016-04-20 19:30 ` [PATCH 1/3] staging/android: remove redundant comments on sync_merge_data Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461203176.1918.3.camel@perches.com \
--to=joe@perches.com \
--cc=John.C.Harrison@Intel.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=arve@android.com \
--cc=daniel.vetter@Intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniels@collabora.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ghackmann@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=gustavo@padovan.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=riandrews@android.com \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome