From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752410AbcDUM13 (ORCPT ); Thu, 21 Apr 2016 08:27:29 -0400 Received: from nat-hk.nvidia.com ([203.18.50.4]:46931 "EHLO hkmmgate102.nvidia.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752373AbcDUM12 (ORCPT ); Thu, 21 Apr 2016 08:27:28 -0400 X-PGP-Universal: processed; by hkpgpgate102.nvidia.com on Thu, 21 Apr 2016 05:27:25 -0700 From: Laxman Dewangan To: CC: , Laxman Dewangan , Benoit Cousson , Felipe Balbi , "Santosh Shilimkar" , Sourav Poddar Subject: [PATCH] mfd: smsc-ece1099: Remove unnecessarily remove callback Date: Thu, 21 Apr 2016 17:45:39 +0530 Message-ID: <1461240939-21110-1-git-send-email-ldewangan@nvidia.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SMSC MFD driver does not add any MFD child devices via mfd_add_devices() and hence it is not required to call mfd_remove_devices() to remove MFD child devices. Remove the call of the API mfd_remove_devices() which will result as remove of .remove callback for driver. Signed-off-by: Laxman Dewangan Cc: Benoit Cousson Cc: Felipe Balbi Cc: Santosh Shilimkar Signed-off-by: Sourav Poddar --- This is build and compile tested only. drivers/mfd/smsc-ece1099.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/mfd/smsc-ece1099.c b/drivers/mfd/smsc-ece1099.c index a4c0df7..7f89e89 100644 --- a/drivers/mfd/smsc-ece1099.c +++ b/drivers/mfd/smsc-ece1099.c @@ -80,15 +80,6 @@ err: return ret; } -static int smsc_i2c_remove(struct i2c_client *i2c) -{ - struct smsc *smsc = i2c_get_clientdata(i2c); - - mfd_remove_devices(smsc->dev); - - return 0; -} - static const struct i2c_device_id smsc_i2c_id[] = { { "smscece1099", 0}, {}, @@ -100,7 +91,6 @@ static struct i2c_driver smsc_i2c_driver = { .name = "smsc", }, .probe = smsc_i2c_probe, - .remove = smsc_i2c_remove, .id_table = smsc_i2c_id, }; -- 2.1.4