From: Paul Burton <paul.burton@imgtec.com>
To: <linux-mips@linux-mips.org>, Ralf Baechle <ralf@linux-mips.org>
Cc: Paul Burton <paul.burton@imgtec.com>,
Markos Chandras <markos.chandras@imgtec.com>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH 08/11] MIPS: math-emu: Fix bit-width in ieee754dp_{mul,maddf,msubf} comments
Date: Thu, 21 Apr 2016 14:04:52 +0100 [thread overview]
Message-ID: <1461243895-30371-9-git-send-email-paul.burton@imgtec.com> (raw)
In-Reply-To: <1461243895-30371-1-git-send-email-paul.burton@imgtec.com>
A comment in ieee754dp_mul indicates that the code is about to perform a
32b x 32b multiplication & keep the high 32b of the result. It appears
this was copied from the single-precision multiplication code, since the
code actually goes on to perform a 64b x 64b multiplication & keep the
high 64b of the result. Fix the comment to indicate 64b.
It appears also that this comment was copied verbatim along with the
rest of the multiplication code into ieee754dp_maddf, which has since
been renamed _dp_maddf. Fix the same issue there.
Signed-off-by: Paul Burton <paul.burton@imgtec.com>
---
arch/mips/math-emu/dp_maddf.c | 2 +-
arch/mips/math-emu/dp_mul.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/mips/math-emu/dp_maddf.c b/arch/mips/math-emu/dp_maddf.c
index 0e1d4d8..dc83fdd 100644
--- a/arch/mips/math-emu/dp_maddf.c
+++ b/arch/mips/math-emu/dp_maddf.c
@@ -165,7 +165,7 @@ static union ieee754dp _dp_maddf(union ieee754dp z, union ieee754dp x,
ym <<= 64 - (DP_FBITS + 1);
/*
- * Multiply 32 bits xm, ym to give high 32 bits rm with stickness.
+ * Multiply 64 bits xm, ym to give high 64 bits rm with stickness.
*/
/* 32 * 32 => 64 */
diff --git a/arch/mips/math-emu/dp_mul.c b/arch/mips/math-emu/dp_mul.c
index d0901f0..d6a7573 100644
--- a/arch/mips/math-emu/dp_mul.c
+++ b/arch/mips/math-emu/dp_mul.c
@@ -125,7 +125,7 @@ union ieee754dp ieee754dp_mul(union ieee754dp x, union ieee754dp y)
ym <<= 64 - (DP_FBITS + 1);
/*
- * Multiply 32 bits xm, ym to give high 32 bits rm with stickness.
+ * Multiply 64 bits xm, ym to give high 64 bits rm with stickness.
*/
/* 32 * 32 => 64 */
--
2.8.0
next prev parent reply other threads:[~2016-04-21 13:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 13:04 [PATCH 00/11] FP emulation fixes Paul Burton
2016-04-21 13:04 ` [PATCH 01/11] MIPS: math-emu: Fix BC1{EQ,NE}Z emulation Paul Burton
2016-05-10 8:09 ` Ralf Baechle
2016-05-10 8:43 ` Paul Burton
2016-05-10 8:54 ` Ralf Baechle
2016-04-21 13:04 ` [PATCH 02/11] MIPS: Fix BC1{EQ,NE}Z return offset calculation Paul Burton
2016-04-21 13:04 ` [PATCH 03/11] MIPS: inst: Declare fsel_op for sel.fmt instruction Paul Burton
2016-04-21 13:04 ` [PATCH 04/11] MIPS: math-emu: Emulate MIPSr6 " Paul Burton
2016-04-21 13:04 ` [PATCH 05/11] MIPS: math-emu: Unify ieee754sp_m{add,sub}f Paul Burton
2016-04-21 13:04 ` [PATCH 06/11] MIPS: math-emu: Unify ieee754dp_m{add,sub}f Paul Burton
2016-04-21 13:04 ` [PATCH 07/11] MIPS: math-emu: Add z argument macros Paul Burton
2016-04-21 13:04 ` Paul Burton [this message]
2016-04-21 13:04 ` [PATCH 09/11] MIPS: math-emu: Fix code indentation Paul Burton
2016-04-21 13:04 ` [PATCH 10/11] MIPS: math-emu: Fix m{add,sub}.s shifts Paul Burton
2016-04-21 13:04 ` [PATCH 11/11] MIPS: math-emu: Fix jalr emulation when rd == $0 Paul Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461243895-30371-9-git-send-email-paul.burton@imgtec.com \
--to=paul.burton@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=markos.chandras@imgtec.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®