From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B875277C96 for ; Sun, 4 Jan 2026 13:45:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767534359; cv=none; b=gaADgrUBOtncYaeR5g17I47ecEbaexS98Mh3EJzUd7PgTDm0njtnCnbRq66PEZJzEW/e1Z5pDs61Lj4RvgZ7Hm3sBHBSp1QIdbGXWH92K5C9lskNuF75ZB5YT+4ixEpqfTEsxiJ4G9F3e0E+TRA1wmYQqDn8OvDxJYnOO3BEPV0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767534359; c=relaxed/simple; bh=ZaU491GHPP0X/mXK+gkH+UwnJTZO6s2faCvGdDKp3x4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ml1tllJMBXEpPaz5Jjei103q+oIvEp3/9HrZwSIP0HGj53yOlgU8z0iNZpdhd1QromzruwidHKTl23VmuNXhYfVEiqwsrndC1OBTkibPnXgEFeUkuRwdI/dq3vjvES3C/YCg/h0Zj+05UcNhKghatVOU/ztSg7lzr5iTcbCpe14= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZrkykxA4; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZrkykxA4" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2a0bb2f093aso133508195ad.3 for ; Sun, 04 Jan 2026 05:45:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767534357; x=1768139157; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+NZZFl+MT1vAjqUFcrCoiCgpusqylZRq7mNgr8aK7XI=; b=ZrkykxA4HZIRx74+G+sdJ1gxQ+NwBRtMoAoAyqmA5WrCxSrK6Y9s/ZDflp/G2YR4rN vcZfyaK0IAe17ukdcpxd1i7AGzX1ENlRs8i+0aCji2vGxtToeqIMZgSE5+a+do5NU4T0 W4x3oOQgzMknAa8TpAWqzcqmmFQzDq5AJEii5d9or59+JD8ERFnbz67awGDgJwgC0Hyu VR2enscLhrcn1GQ6AVXunQO0TCWc/Qmo/i2TywjH1U7HWu5xMYJY85DuYgxYYJPWNz1+ X3fSshPPypNmg9oE2TN6XZt6PmsaFOKA/Zdp2lEEGlosgbqtGdiVkpAnjTimaBkc8y+D Opxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767534357; x=1768139157; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+NZZFl+MT1vAjqUFcrCoiCgpusqylZRq7mNgr8aK7XI=; b=NF0FK8WhkwWWf5X2TuIR6qAZURKvhV0FDKxwupY2h28Ba+UAVK3NImIs0eBlMT7Jh4 4WyzNgZduIxuy856Gg2KN6ZUYbtwkfesGYtlstHB0MZDFos5wueFTtgj6D4k49BKaml1 9eT0jijd0rA5Ya9mr7WIYDq7QZ1RF9WuEhn03KtJ1yf3/6nZZmJf/FfGiny9AfYszB0m pBssV6/4qr4QDHzSrczlWp7zBrR8gjaJbwc+r/BhbgSsBJ6zkqsKAaFQcdEKvJ5W75fG T/8+F/9a02NrQIALiDC4cxG6gpgTqUSZdOpNCPQroS7O+K7S0XH/ywpJi1JOaOjweAH8 P47w== X-Forwarded-Encrypted: i=1; AJvYcCXrvX0Sat9PHVcWHN3N9KEiKDXog3ZDUQ13lonDoWlMQM3dGEEGQk2Kgt0G/CTwEpGNsOqVmbXzl5zKv+k=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4fr2Ugf26SLrEok9Zckx36/qshR8gGoTRsbZUJy9oojYwNSmD WKnPLbmLrY5lqYkEos/NwReDeVIvumQTVOqAvYoq0+62cIDxgWQdJIyl X-Gm-Gg: AY/fxX75W9ijUpVbK5QCqRxJryHJe+L4DamnNNJH7QHQzfPZNUOm4WTmGPdYbLt2Bdn kXtRiIRNfKcvIXIWJ7bQB7BSIVi2OO1Tm89WYAARdG14hsOz89ExN8vAdTCOvG85tv7FvV0UNJk UikmXXZnjDgsrITirBBFhrJwMa4PSgy2iBAzDTwnaZyTd7IZDFA9aWuRDxvMD0sCls5selOQS1R +67Wrnv5rnvG7gunFraOng7tSkV2d40+q8dG+96sNApfPWUxjczNGiD4ykga2rWS889kMXCXQsi nFoBJa01VAkCdUVOhodAPb0JnsH8bzy1odL/RS3/ocM0JQ/STQzdOT78AFGW6FClpK0Rqrys1SV LtPOIUneawT0wkJb+kSUEbctmdmWGfdonWGisiIHGg4QccoU+T0r5p8gQFrJqctpyjRWFKUbz19 VUt6yJOmq7DkXZAn0gOCHHOJdjGEv80me8nZIC X-Google-Smtp-Source: AGHT+IEDApM6jMUqXmOQC79GFfIC4sIy6cb+Qboy5rbJD8Tyd7ltuTIgica7oqnktpgaeoZ9nZgMgg== X-Received: by 2002:a17:902:cecb:b0:2a0:8859:3722 with SMTP id d9443c01a7336-2a2f232baa8mr372016715ad.25.1767534356794; Sun, 04 Jan 2026 05:45:56 -0800 (PST) Received: from [192.168.31.239] ([167.103.54.183]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3c82bbesm431959055ad.35.2026.01.04.05.45.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Jan 2026 05:45:56 -0800 (PST) Message-ID: <14613f89-6be0-4eb3-beb5-375ab008a313@gmail.com> Date: Sun, 4 Jan 2026 19:16:20 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 5/5] arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board To: Konrad Dybcio , andersson@kernel.org, konradybcio@kernel.org Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251230130227.3503590-1-tessolveupstream@gmail.com> <20251230130227.3503590-6-tessolveupstream@gmail.com> <30ee8541-3ec2-49ac-8fe0-987cdc5b16e7@oss.qualcomm.com> Content-Language: en-US From: tessolveupstream@gmail.com In-Reply-To: <30ee8541-3ec2-49ac-8fe0-987cdc5b16e7@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 30-12-2025 20:21, Konrad Dybcio wrote: > On 12/30/25 2:02 PM, Sudarshan Shetty wrote: >> Add the device tree for the QCS615-based Talos EVK platform. The >> platform is composed of a System-on-Module following the SMARC >> standard, and a Carrier Board. >> >> The Carrier Board supports several display configurations, HDMI and >> LVDS. Both configurations use the same base hardware, with the display >> selection controlled by a DIP switch. > > [...] > >> +++ b/arch/arm64/boot/dts/qcom/talos-evk-lvds-auo,g133han01.dtso >> @@ -0,0 +1,126 @@ >> +// SPDX-License-Identifier: BSD-3-Clause >> +/* >> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> + */ >> +/dts-v1/; >> +/plugin/; >> + >> +#include >> + >> +&{/} { >> + backlight: backlight { >> + compatible = "gpio-backlight"; >> + gpios = <&tlmm 59 GPIO_ACTIVE_HIGH>, >> + <&tlmm 115 GPIO_ACTIVE_HIGH>; >> + default-on; >> + }; >> + >> + hdmi_connector: hdmi-out { >> + status = "disabled"; >> + }; > > This should be a &label_reference > Okay, will add it in the next patch. > [...] > >> + wifi_1p8v: regulator-wifi-1p8v { >> + compatible = "regulator-fixed"; >> + regulator-name = "wifi_1p8v"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + gpio = <&tlmm 91 GPIO_ACTIVE_HIGH>; >> + enable-active-high; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&wifi_reg_en_pins_state>; > > property-n > property-names > > consistently, please > I didn’t fully understand your comment. Could you please elaborate a bit more so I can make the necessary changes correctly. >> + regulator-boot-on; >> + regulator-always-on; >> + }; >> + >> + wifi_3p85v: regulator-wifi-3p85v { >> + compatible = "regulator-fixed"; >> + regulator-name = "wifi_3p85v"; >> + regulator-min-microvolt = <3850000>; >> + regulator-max-microvolt = <3850000>; >> + gpio = <&tlmm 91 GPIO_ACTIVE_HIGH>; >> + enable-active-high; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&wifi_reg_en_pins_state>; > > ditto > > [...] > >> +&tlmm { >> + bt_en_state: bt-en-state { >> + pins = "gpio85"; >> + function = "gpio"; >> + bias-pull-down; >> + output-low; > > output-low/high should be unnecessary as these pins are governed > by the kernel driver > Okay,got it. Will make the necessary change in the next patch. > lg otherwise > > Konrad