From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752984AbcDXQn0 (ORCPT ); Sun, 24 Apr 2016 12:43:26 -0400 Received: from smtprelay0233.hostedemail.com ([216.40.44.233]:48344 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752818AbcDXQnZ (ORCPT ); Sun, 24 Apr 2016 12:43:25 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:560:599:960:967:973:988:989:1260:1263:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2110:2194:2196:2199:2200:2393:2525:2553:2561:2564:2682:2685:2693:2737:2828:2859:2915:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4250:4321:5007:6117:6119:7903:7974:8599:8985:9025:9108:9388:10004:10049:10400:10450:10455:10848:11026:11232:11257:11258:11658:11854:11914:12043:12296:12517:12519:12663:12682:12740:12776:13069:13095:13161:13229:13311:13357:13439:13894:14181:14651:14659:14721:14764:19904:19999:21080:21325:30012:30025:30034:30054:30056:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: chain98_1d6a3fc501a00 X-Filterd-Recvd-Size: 2933 Message-ID: <1461516200.2726.73.camel@perches.com> Subject: Re: [PATCH v2 3/6] crypto: Linux Random Number Generator From: Joe Perches To: Stephan Mueller Cc: herbert@gondor.apana.org.au, Theodore Tso , sandyinchina@gmail.com, Jason Cooper , John Denker , "H. Peter Anvin" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sun, 24 Apr 2016 09:43:20 -0700 In-Reply-To: <1907949.voNH4FmKbt@positron.chronox.de> References: <1589319.WyasadRQQe@positron.chronox.de> <4513249.IuhZztB3y6@positron.chronox.de> <1461497424.2726.55.camel@perches.com> <1907949.voNH4FmKbt@positron.chronox.de> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-04-24 at 16:12 +0200, Stephan Mueller wrote: > Am Sonntag, 24. April 2016, 04:30:24 schrieb Joe Perches: > > On Sun, 2016-04-24 at 12:40 +0200, Stephan Mueller wrote: > > > The LRNG with all its properties is documented in [1]. This > > > documentation covers the functional discussion as well as testing of all > > > aspects of entropy processing. In addition, the documentation explains > > > the conducted regression tests to verify that the LRNG is API and ABI > > > compatible with the legacy /dev/random implementation. > > > [1] http://www.chronox.de/lrng.html > > Links get stale. > > It may be better to put an ascii version of the pdf > > in Documentation/ and the test code in tools/ > I surely can do that. What would you think would be the proper location to add  > such documentation? Simply Documentation/lrng.txt? > > How would you propose to handle the pictures (at least the big picture)? I think figure 2.1 could look ok using something like asciio. http://search.cpan.org/dist/App-Asciio/lib/App/Asciio.pm > Regarding the tests: those are no regression tests, but tests to allow other  > researches to verify whether the LRNG operates appropriately. Thus, would  > adding it to a new directory of tools/crypto/rng be appropriate? Whatever you think best would be fine with me. > > > + pr_info(DRIVER_NAME": deactivating initial RNG - %d bytes delivered", > > > + atomic_read(&lrng_initrng_bytes)); > > Should use \n to terminate the format. > Thank you, fixed. Though, I am wondering why I do see the line feed in dmesg.  The kernel will add a newline to dmesg output whenever a new KERN_ is used, but there can be unprefixed content or KERN_CONT uses from another thread before another message that can unintentionally extend an old message without a newline termination. cheers, Joe