From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752888AbcDXRGU (ORCPT ); Sun, 24 Apr 2016 13:06:20 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:33835 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752583AbcDXRGS (ORCPT ); Sun, 24 Apr 2016 13:06:18 -0400 From: Konstantin Shkolnyy To: johan@kernel.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Konstantin Shkolnyy Subject: [PATCH RESEND 2/5] USB: serial: cp210x: Made sure SERIAL_XOFF_CONTINUE flag is clear. Date: Sun, 24 Apr 2016 12:09:10 -0500 Message-Id: <1461517750-6205-1-git-send-email-konstantin.shkolnyy@gmail.com> X-Mailer: git-send-email 1.8.4.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The CRTCTS flag code intended to clear the SERIAL_XOFF_CONTINUE flag, but did it inconsistently. This change is non-functional for existing chips because the driver never set the flag and it's clear by default. Signed-off-by: Konstantin Shkolnyy --- drivers/usb/serial/cp210x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c index de1606f..ede5c52 100644 --- a/drivers/usb/serial/cp210x.c +++ b/drivers/usb/serial/cp210x.c @@ -955,7 +955,6 @@ static void cp210x_set_termios(struct tty_struct *tty, modem_ctl[0] &= ~0x7B; modem_ctl[0] |= 0x09; modem_ctl[4] = 0x80; - modem_ctl[7] = 0; dev_dbg(dev, "%s - flow control = CRTSCTS\n", __func__); } else { modem_ctl[0] &= ~0x7B; @@ -963,6 +962,7 @@ static void cp210x_set_termios(struct tty_struct *tty, modem_ctl[4] = 0x40; dev_dbg(dev, "%s - flow control = NONE\n", __func__); } + modem_ctl[7] = 0; dev_dbg(dev, "%s - write modem controls = %02x .. .. .. %02x .. .. %02x\n", __func__, modem_ctl[0], modem_ctl[4], modem_ctl[7]); -- 1.8.4.5