From: Ming Lei <ming.lei@canonical.com>
To: Jens Axboe <axboe@fb.com>, linux-kernel@vger.kernel.org
Cc: linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
linux-btrfs@vger.kernel.org, Ming Lei <ming.lei@canonical.com>,
linux-fsdevel@vger.kernel.org (open list:FILESYSTEMS (VFS and
infrastructure))
Subject: [PATCH v3 0/3] block: avoid to call .bi_end_io() recursively
Date: Thu, 28 Apr 2016 09:09:00 +0800 [thread overview]
Message-ID: <1461805743-3559-1-git-send-email-ming.lei@canonical.com> (raw)
Hi,
The 1st patch handles bio error in dio_end_io() which is only
used by btrfs.
The 2nd patch uses bio_endio() to call .bi_end_io() in dio_end_io().
The 3rd patch avoids to call .bi_end_io recursively in complete path.
xfstests(-g auto) is run over ext4, xfs and btrfs with this patchset
and no regression is reported.
With this patchset, lots of stack space can be saved in bio complete
path. Even there was stack overflow report in bio complete path, see
details in 3/3 commit log.
V3:
- no behaviour change
- reorganize the function of unwind_bio_endio() and make it
more clean
V2:
- introduce patch 1 & 2
- deal with running bio_endio() from process context, and
makes generic/323 & generic/224 of xfstests happy on btrfs
V1:
- change to RFC
- fix when unwind_bio_endio() is called recursively
- run xfstest again: no regression found on ext4,
but generic/323 and generic/224 cause kernel oops
Ming Lei (3):
fs: direct-io: handle error in dio_end_io()
fs: direct-io: call .bi_end_io via bio_endio()
bflock: avoid to call .bi_end_io() recursively
block/bio.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++++--
fs/direct-io.c | 8 +++-----
2 files changed, 56 insertions(+), 7 deletions(-)
--
1.9.1
next reply other threads:[~2016-04-28 1:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 1:09 Ming Lei [this message]
2016-05-02 14:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461805743-3559-1-git-send-email-ming.lei@canonical.com \
--to=ming.lei@canonical.com \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®