From: Gustavo Padovan <gustavo@padovan.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
dri-devel@lists.freedesktop.org,
"Daniel Stone" <daniels@collabora.com>,
"Arve Hjønnevåg" <arve@android.com>,
"Riley Andrews" <riandrews@android.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Rob Clark" <robdclark@gmail.com>,
"Greg Hackmann" <ghackmann@google.com>,
"John Harrison" <John.C.Harrison@Intel.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Gustavo Padovan" <gustavo.padovan@collabora.co.uk>
Subject: [PATCH v2 01/13] staging/android: remove redundant comments on sync_merge_data
Date: Thu, 28 Apr 2016 10:46:48 -0300 [thread overview]
Message-ID: <1461851220-1583-2-git-send-email-gustavo@padovan.org> (raw)
In-Reply-To: <1461851220-1583-1-git-send-email-gustavo@padovan.org>
From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
struct sync_merge_data already have documentation on top of the
struct definition. No need to duplicate it.
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/staging/android/uapi/sync.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/android/uapi/sync.h b/drivers/staging/android/uapi/sync.h
index 7de5d6a..413303d 100644
--- a/drivers/staging/android/uapi/sync.h
+++ b/drivers/staging/android/uapi/sync.h
@@ -23,9 +23,9 @@
* @pad: padding for 64-bit alignment, should always be zero
*/
struct sync_merge_data {
- char name[32]; /* name of new fence */
- __s32 fd2; /* fd of second fence */
- __s32 fence; /* fd on newly created fence */
+ char name[32];
+ __s32 fd2;
+ __s32 fence;
__u32 flags;
__u32 pad;
};
@@ -33,8 +33,8 @@ struct sync_merge_data {
/**
* struct sync_fence_info - detailed fence information
* @obj_name: name of parent sync_timeline
- * @driver_name: name of driver implementing the parent
- * @status: status of the fence 0:active 1:signaled <0:error
+* @driver_name: name of driver implementing the parent
+* @status: status of the fence 0:active 1:signaled <0:error
* @flags: fence_info flags
* @timestamp_ns: timestamp of status change in nanoseconds
*/
--
2.5.5
next prev parent reply other threads:[~2016-04-28 13:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 13:46 [PATCH v2 00/13] De-stage Sync File Framework Gustavo Padovan
2016-04-28 13:46 ` Gustavo Padovan [this message]
2016-04-28 13:46 ` [PATCH v2 02/13] staging/android: drop sync_file_install() and sync_file_put() Gustavo Padovan
2016-04-28 13:46 ` [PATCH v2 03/13] staging/android: move sync_file functions comments to sync.c Gustavo Padovan
2016-04-28 13:46 ` [PATCH v2 04/13] staging/android: make sync_file_merge() static Gustavo Padovan
2016-04-28 13:46 ` [PATCH v2 05/13] staging/android: make sync_file_fdget() static Gustavo Padovan
2016-04-28 13:46 ` [PATCH v2 06/13] staging/android: remove name arg from sync_file_create() Gustavo Padovan
2016-04-28 13:46 ` [PATCH v2 07/13] staging/android: prepare sync_file for de-staging Gustavo Padovan
2016-04-28 13:46 ` [PATCH v2 08/13] staging/android: improve documentation for sync_file Gustavo Padovan
2016-04-28 13:46 ` [PATCH v2 09/13] staging/android: style fix: alignment to match the open parenthesis Gustavo Padovan
2016-04-28 13:46 ` [PATCH v2 10/13] dma-buf/sync_file: de-stage sync_file headers Gustavo Padovan
2016-04-28 13:46 ` [PATCH v2 11/13] dma-buf/sync_file: de-stage sync_file Gustavo Padovan
2016-04-28 13:46 ` [PATCH v2 12/13] Documentation: include sync_file into DocBook Gustavo Padovan
2016-04-28 13:47 ` [PATCH v2 13/13] Documentation: add Sync File doc Gustavo Padovan
2016-04-30 0:39 ` [PATCH v2 00/13] De-stage Sync File Framework Greg Kroah-Hartman
[not found] <00d201d1a1eb$86be73f0$943b5bd0$@alibaba-inc.com>
2016-04-29 7:53 ` [PATCH v2 01/13] staging/android: remove redundant comments on sync_merge_data Hillf Danton
2016-04-29 13:30 ` Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461851220-1583-2-git-send-email-gustavo@padovan.org \
--to=gustavo@padovan.org \
--cc=John.C.Harrison@Intel.com \
--cc=arve@android.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniels@collabora.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ghackmann@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=riandrews@android.com \
--cc=robdclark@gmail.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®