mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <tony@atomide.com>
Cc: <linux-omap@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH] ARM: dts: omap5-igep0050: Correct hdmi regulator
Date: Fri, 29 Apr 2016 13:21:37 +0300	[thread overview]
Message-ID: <1461925297-9734-1-git-send-email-peter.ujfalusi@ti.com> (raw)

ldo7_reg should not work as regulator since it is set to 'disabled' state
in the omap5-board-common.dtsi and the state is not changed to 'okay'
this means that the ldo7_reg is not available to be used in the igep0050
DTS file.
ldo4_reg is used by all other OMAP5 boards and this is most likely the
correct regulator to use with hdmi.
The hdmi needs 1.8V, but the ldo7_reg, based on the dtsi is 2V only.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
Tony,

I don't have access to the schematics, but I believe tha the ldo7_reg is not the
correct regulator to be used for hdmi.

If you have access and it is really ldo7_reg, then we should have this in the
omap5-igep0050.dts file:

&ldo5_reg {
	status = "okay";
	regulator-min-microvolt = <1800000>;
	regulator-max-microvolt = <1800000>;
};

Regards,
Peter

 arch/arm/boot/dts/omap5-igep0050.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/omap5-igep0050.dts b/arch/arm/boot/dts/omap5-igep0050.dts
index 46ecb1dd3b5c..6c8d40327c68 100644
--- a/arch/arm/boot/dts/omap5-igep0050.dts
+++ b/arch/arm/boot/dts/omap5-igep0050.dts
@@ -20,7 +20,7 @@
 };
 
 &hdmi {
-	vdda-supply = <&ldo7_reg>;
+	vdda-supply = <&ldo4_reg>;
 };
 
 &i2c4 {
-- 
2.8.1

             reply	other threads:[~2016-04-29 12:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-29 10:21 Peter Ujfalusi [this message]
2016-04-29 10:22 ` Peter Ujfalusi
2016-05-04 17:26   ` Tony Lindgren
2016-05-04 18:01     ` Nishanth Menon
2016-05-05 18:46       ` Tony Lindgren
2016-05-09  8:25         ` Peter Ujfalusi
2016-05-09  8:34           ` Tomi Valkeinen
     [not found]         ` <2822D1C2B9B19F4A8261F756A13373F801BEF7B4@DFLE11.ent.ti.com>
     [not found]           ` <CAPjucKb+4vd8Ar3MATCuTx+9R36PeB0hbvwDaAD1KTZFCiVJEA@mail.gmail.com>
     [not found]             ` <2822D1C2B9B19F4A8261F756A13373F801BF86D2@DFLE11.ent.ti.com>
     [not found]               ` <2822D1C2B9B19F4A8261F756A13373F801BF8703@DFLE11.ent.ti.com>
     [not found]                 ` <CAPjucKb2PLSZcD3YZ9xQk1F62ugFaGAkBBqMp5GmoWFd0H8Vfg@mail.gmail.com>
2016-05-12 16:57                   ` Tony Lindgren
2016-05-12 19:19                     ` Nishanth Menon
2016-05-12 20:26                       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461925297-9734-1-git-send-email-peter.ujfalusi@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®