From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752346AbcEAMwV (ORCPT ); Sun, 1 May 2016 08:52:21 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:34871 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752057AbcEAMwQ (ORCPT ); Sun, 1 May 2016 08:52:16 -0400 From: Muhammad Falak R Wani To: "Nicholas A. Bellinger" Cc: target-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] target: use RCU_INIT_POINTER() when NULLing. Date: Sun, 1 May 2016 18:22:02 +0530 Message-Id: <1462107122-9562-2-git-send-email-falakreyaz@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1462107122-9562-1-git-send-email-falakreyaz@gmail.com> References: <1462107122-9562-1-git-send-email-falakreyaz@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is safe to use RCU_INIT_POINTER() to NULL, instead of rcu_assign_pointer(). This results in slightly smaller/faster code. The follwoing semantic patch was used: @@ @@ - rcu_assign_pointer + RCU_INIT_POINTER (..., NULL) Signed-off-by: Muhammad Falak R Wani --- drivers/target/target_core_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c index a4046ca..6f81e3b 100644 --- a/drivers/target/target_core_device.c +++ b/drivers/target/target_core_device.c @@ -432,8 +432,8 @@ void core_disable_device_list_for_node( kref_put(&orig->pr_kref, target_pr_kref_release); wait_for_completion(&orig->pr_comp); - rcu_assign_pointer(orig->se_lun, NULL); - rcu_assign_pointer(orig->se_lun_acl, NULL); + RCU_INIT_POINTER(orig->se_lun, NULL); + RCU_INIT_POINTER(orig->se_lun_acl, NULL); kfree_rcu(orig, rcu_head); -- 1.9.1