From: Boqun Feng <boqun.feng@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Josh Triplett <josh@joshtriplett.org>,
Boqun Feng <boqun.feng@gmail.com>
Subject: [RFC rcu/next] torture: Stop onoff task if there is only one cpu
Date: Mon, 2 May 2016 10:30:00 +0800 [thread overview]
Message-ID: <1462156200-4811-1-git-send-email-boqun.feng@gmail.com> (raw)
If the whole system has only one cpu, that cpu won't be able to be
offlined, so there is no need onoff task is stil running.
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
---
I hit something like the following while I was running rcutorture
in a guest with only one vCPU:
[ 31.197457] rcu-torture:torture_onoff task: offlining 0
[ 31.197508] rcu-torture:torture_onoff task: offline 0 failed: errno -16
I know this is an expected behavior, but think we could just stop
the onoff task if there is only one cpu.
kernel/torture.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/kernel/torture.c b/kernel/torture.c
index fb39a06bbef5..a85b7d61d9dd 100644
--- a/kernel/torture.c
+++ b/kernel/torture.c
@@ -194,6 +194,12 @@ torture_onoff(void *arg)
for_each_online_cpu(cpu)
maxcpu = cpu;
WARN_ON(maxcpu < 0);
+
+ if (maxcpu == 0) {
+ VERBOSE_TOROUT_STRING("only one cpu is found, onoff is impossible");
+ goto stop;
+ }
+
if (onoff_holdoff > 0) {
VERBOSE_TOROUT_STRING("torture_onoff begin holdoff");
schedule_timeout_interruptible(onoff_holdoff);
@@ -209,6 +215,8 @@ torture_onoff(void *arg)
&sum_online, &min_online, &max_online);
schedule_timeout_interruptible(onoff_interval);
}
+
+stop:
torture_kthread_stopping("torture_onoff");
return 0;
}
--
2.8.0
next reply other threads:[~2016-05-02 2:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 2:30 Boqun Feng [this message]
2016-05-02 17:18 ` Josh Triplett
2016-05-02 19:30 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462156200-4811-1-git-send-email-boqun.feng@gmail.com \
--to=boqun.feng@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®