From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753333AbcEBI0i (ORCPT ); Mon, 2 May 2016 04:26:38 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:39377 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753091AbcEBI03 (ORCPT ); Mon, 2 May 2016 04:26:29 -0400 Message-ID: <1462177581.3933.7.camel@pengutronix.de> Subject: Re: [PATCH 3/7] reset: lpc18xx: use devm_reset_controller_register() From: Philipp Zabel To: Masahiro Yamada Cc: linux-arm-kernel@lists.infradead.org, Joachim Eastwood , linux-kernel@vger.kernel.org Date: Mon, 02 May 2016 10:26:21 +0200 In-Reply-To: <1462099023-11819-4-git-send-email-yamada.masahiro@socionext.com> References: <1462099023-11819-1-git-send-email-yamada.masahiro@socionext.com> <1462099023-11819-4-git-send-email-yamada.masahiro@socionext.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Sonntag, den 01.05.2016, 19:36 +0900 schrieb Masahiro Yamada: > Use devm_reset_controller_register() for the reset controller > registration and remove the unregister call from the .remove callback. > > Signed-off-by: Masahiro Yamada > --- > > drivers/reset/reset-lpc18xx.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/reset/reset-lpc18xx.c b/drivers/reset/reset-lpc18xx.c > index 3b8a4f5..dd4f27e 100644 > --- a/drivers/reset/reset-lpc18xx.c > +++ b/drivers/reset/reset-lpc18xx.c > @@ -199,7 +199,7 @@ static int lpc18xx_rgu_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, rc); > > - ret = reset_controller_register(&rc->rcdev); > + ret = devm_reset_controller_register(&pdev->dev, &rc->rcdev); > if (ret) { > dev_err(&pdev->dev, "unable to register device\n"); > goto dis_clks; > @@ -229,8 +229,6 @@ static int lpc18xx_rgu_remove(struct platform_device *pdev) > if (ret) > dev_warn(&pdev->dev, "failed to unregister restart handler\n"); > > - reset_controller_unregister(&rc->rcdev); > - > clk_disable_unprepare(rc->clk_delay); > clk_disable_unprepare(rc->clk_reg); > Hmm, would this patch theoretically allow a window between the calls to clk_disable_unprepare(clk_reg) and devm_reset_controller_release() where reset_control_get() + reset_control_(de)assert() would access unclocked registers? regards Philipp