From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754003AbcEBOl3 (ORCPT ); Mon, 2 May 2016 10:41:29 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:1774 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753896AbcEBOlK (ORCPT ); Mon, 2 May 2016 10:41:10 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Mon, 02 May 2016 07:40:12 -0700 From: Laxman Dewangan To: , , CC: , , , , , "Laxman Dewangan" Subject: [PATCH] pinctrl: tegra: Correctly check the supported configuration Date: Mon, 2 May 2016 19:58:50 +0530 Message-ID: <1462199330-1536-2-git-send-email-ldewangan@nvidia.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1462199330-1536-1-git-send-email-ldewangan@nvidia.com> References: <1462199330-1536-1-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The pincontrol registers of Tegra chips has multiple filed per registers. There is two type of registers mux and drive. All configurations belongs to one of these registers. If any configurations are supported then _bit is set to bit position of these registers otherwise -1 to not support it. The member is defined as s32 _bit:6; So if config is not supported ifor given SoC then it is set to -1 in soc pinmmux table. In common driver code, to find out that given config is supported or not, it is checked as: s8 bit = _bit; if (bit > 31) { /* Not supported */ } But in this case, bit is s8 and hence for non supporting it is -1. Correct the check as: if (bit < 0 || bit > 31) { /* Not supported */ } Signed-off-by: Laxman Dewangan --- I think it should go on stable. drivers/pinctrl/tegra/pinctrl-tegra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c index fb00129..cc117f7 100644 --- a/drivers/pinctrl/tegra/pinctrl-tegra.c +++ b/drivers/pinctrl/tegra/pinctrl-tegra.c @@ -417,7 +417,7 @@ static int tegra_pinconf_reg(struct tegra_pmx *pmx, return -ENOTSUPP; } - if (*reg < 0 || *bit > 31) { + if (*reg < 0 || *bit < 0 || *bit > 31) { if (report_err) { const char *prop = "unknown"; int i; -- 2.1.4