From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933358AbcECPXj (ORCPT ); Tue, 3 May 2016 11:23:39 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:52263 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756161AbcECPXh (ORCPT ); Tue, 3 May 2016 11:23:37 -0400 Message-ID: <1462288967.17662.107.camel@decadent.org.uk> Subject: Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop From: Ben Hutchings To: Oleg Nesterov , Andrew Morton Cc: Oleksandr Natalenko , Lee Jones , Wolfram Sang , Roger Tseng , linux-kernel@vger.kernel.org Date: Tue, 03 May 2016 17:22:47 +0200 In-Reply-To: <20160503134009.GA26668@redhat.com> References: <7afcd6e57d09772699ac37b59db98617@natalenko.name> <20160502135634.ccbfb7f58798b7a217319b98@linux-foundation.org> <20160503134009.GA26668@redhat.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-tlec8K0Zhhy86l7rudJD" X-Mailer: Evolution 3.18.5.1-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2a02:8388:8800:c080:5577:7479:965b:36af X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-tlec8K0Zhhy86l7rudJD Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2016-05-03 at 15:40 +0200, Oleg Nesterov wrote: > On 05/02, Andrew Morton wrote: > >=20 > >=20 > > On Mon, 02 May 2016 23:17:41 +0300 Oleksandr Natalenko wrote: > >=20 > > >=20 > > > rtsx_usb_ms creates a task that mostly sleeps, but tasks in > > > uninterruptible sleep still contribute to the load average (for > > > bug-compatibility with Unix). > We have TASK_NOLOAD/TASK_IDLE, you can just use schedule_timeout_idle(HZ)= . [...] I wasn't aware of that function... ah, that would be because it's new in 4.6. =C2=A0It seems much clearer to use that than to use msleep_interruptible() and ignore the result. Ben. --=20 Ben Hutchings In a hierarchy, every employee tends to rise to his level of incompetence. --=-tlec8K0Zhhy86l7rudJD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJXKMJHAAoJEOe/yOyVhhEJPdoP/RsW8Upv8cK8em5cWDxsfkYh cja3xSN1RlZHx93YjrOxAtgwFkbcEsVn350tXo6Wco0OdGS5zv+W7FuOQyNz38ih HCbG//axn9faYsC8x6rTW+Vy7KqgwF0quvhzqZxKAE8e7q1raukfZzgKNLjTvz0D GTS5XXgSwou50owGSkGBmADu1z4bYmc7fbUO7fUEhO7mJSzvj9wNPYLsQycM5qXX pdwaCM2DU2R5SSUQQogpF4s/WsMJ1OSRtwZg49NOzTpu3UntLbrP4Z3AbcPA/xzr euKMJM0iEqlpscauPPbHGTmQ5AaZ7zg4p1hzcv+pueJIPZ4JvXIIvCvDqeaygmFX 6CYyzH5VUr44BxJtIIFCznAeXqtP+r+ard/4Om30XRTNAxTTcoJgxlpSuFIM/KIk 09Q3DgEveSIR0z417Wwu8u7TVhCG0/C1j9QsEEvh+QLcimLvBDdpL8dmiwgtdEvQ UwRuA5LcFuBxky8Kt5yNRCQDMAhN5tty9OiEkchA6qaTuV0KVOKM4XDf8ScPHMMu 6QbRMThnZMZy3FO5QKk0WWLD887OvByyZ2TmCUQagb1puMD7Oseffzt5cDh9A+1E kp+GXTw6c8ntbXIAV3VVhrzhAEGB4pq9+mOf2lVyUm6UcJunooOLQn2h7LTepF1o gbn/VZyVoNqbR6eRcUr6 =Ovya -----END PGP SIGNATURE----- --=-tlec8K0Zhhy86l7rudJD--