From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933519AbcECPYR (ORCPT ); Tue, 3 May 2016 11:24:17 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:55242 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933006AbcECPYP (ORCPT ); Tue, 3 May 2016 11:24:15 -0400 From: Arnd Bergmann To: Maxime Ripard , David Airlie , Chen-Yu Tsai Cc: Arnd Bergmann , Boris Brezillon , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm: sun4i: print DMA address correctly Date: Tue, 3 May 2016 17:23:28 +0200 Message-Id: <1462289020-774976-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:SQozKrh3Lpx0Hv24iTdckS1HyQqza7jaAkeKJ4vFgsAXVHpl2Vh qnD+R0i9l9NQolyuLlz4D/we7hzMJdyBi9TGlzi16jEE33tDRfNkuUlSt6NvFu5rXI2Wfza 8FrbR0vZcpENTEaTOsCPdVPbkB1nlpzXb5zvDwQXiZjAOI7cfiOTpJIjT4K02RtF/iGHUDB gTwharM9OKvVnqiuaFHKw== X-UI-Out-Filterresults: notjunk:1;V01:K0:p+p2SJiGqEs=:H7+dLUhgf5LWiyxTyq3j8f 7BX5oDtwuytqzTSQE5tqoW+KXOWtxSxfE3dg6rdHII6GBV9wL5mG8zXhyk6P72t2WZoh5RGWz xzMEJI7vwxyrtFY4uUEhJBUx0LvOnkZtahI2hHBsQpDQapbQ3L3wW+w7ecrzL8QKivxI1Suoh Dby359OX3Tg379fMz1SRNgdteSDARjy5gAdJDAOG9fUKzWaeznRKER9x8L/Oap5r+lK2ck6U/ /l/lbwiUVhlORhaTmiBHFANfUG1h87Eq18gWK76wDKHHX4BHHrCscOGRP2gzz+uuFKlr78uGZ tk4ASnLr/c8U2NWTIPD+t7nJaJsO7c92oVzXrmK75SBhsbMls/2cJ9glvgYei+/0R1FnsBRzd drtii/FfuSbiJM4gsPmlL92YZfk+7ZhTQn/mdJQzmJNtuIM0po8fr7aoY22K5tc9ezm8Sb6m6 /w3+KVqKPyF5tnuT5Lmx8T3GuuPr4a5ZOkUbSfPhN3wjnIKj6sx3Zirt6ukVV8w7yHlwWX6FS uVi6Qa1aN1XpDQOg1l4Z95nHtRGkjgUofaBkg2NpNMbJkbp1D2tyfPKyrcg7DRV3Xty7a2FBX G9devBaDeMagVikS+Eg6aoT6PC8OLtzhW0/27WFIUsrTrgOzKANe0JjzUrF6LA/WyvjKkdwT/ TwyE3HRSg23YUfv+3vxaTa/oC16SmVZoYwe96cFkMeov/aJXNeMdMZseINbb9an0+gyo= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The newly added sun4i drm driver prints a dma address using the %x format string, which cannot work when dma_addr_t is 64 bit, and gcc warns about this configuration: drm/sun4i/sun4i_backend.c: In function 'sun4i_backend_update_layer_buffer': drm/sun4i/sun4i_backend.c:193:84: error: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'dma_addr_t {aka long long unsigned int}' [-Werror=format=] DRM_DEBUG_DRIVER("Using GEM @ 0x%x\n", gem->paddr); drm/sun4i/sun4i_backend.c:201:84: error: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'dma_addr_t {aka long long unsigned int}' [-Werror=format=] DRM_DEBUG_DRIVER("Setting buffer address to 0x%x\n", paddr); This changes the code to use the explicit %pad format string, which always prints the right length. Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/sun4i/sun4i_backend.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/sun4i_backend.c index f7a15c1a93bf..3ab560450a82 100644 --- a/drivers/gpu/drm/sun4i/sun4i_backend.c +++ b/drivers/gpu/drm/sun4i/sun4i_backend.c @@ -190,7 +190,7 @@ int sun4i_backend_update_layer_buffer(struct sun4i_backend *backend, /* Get the physical address of the buffer in memory */ gem = drm_fb_cma_get_gem_obj(fb, 0); - DRM_DEBUG_DRIVER("Using GEM @ 0x%x\n", gem->paddr); + DRM_DEBUG_DRIVER("Using GEM @ %pad\n", &gem->paddr); /* Compute the start of the displayed memory */ bpp = drm_format_plane_cpp(fb->pixel_format, 0); @@ -198,7 +198,7 @@ int sun4i_backend_update_layer_buffer(struct sun4i_backend *backend, paddr += (state->src_x >> 16) * bpp; paddr += (state->src_y >> 16) * fb->pitches[0]; - DRM_DEBUG_DRIVER("Setting buffer address to 0x%x\n", paddr); + DRM_DEBUG_DRIVER("Setting buffer address to %pad\n", &paddr); /* Write the 32 lower bits of the address (in bits) */ lo_paddr = paddr << 3; -- 2.7.0