From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934182AbcECS7J (ORCPT ); Tue, 3 May 2016 14:59:09 -0400 Received: from mail-pf0-f175.google.com ([209.85.192.175]:35687 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933291AbcECS7I (ORCPT ); Tue, 3 May 2016 14:59:08 -0400 From: Muhammad Falak R Wani To: Herbert Xu Cc: "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] crypto: algif_skcipher: replace sg++ with sg_next() Date: Wed, 4 May 2016 00:28:08 +0530 Message-Id: <1462301939-23578-1-git-send-email-falakreyaz@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Never use sg++, always use sg = sg_next(sg). Scatterlist entries can be combined if the memory is contiguous but sg++ won't know about that. It sure would run on the slower side. But regardless, sg++ should never be used, only sg_next is safe. Signed-off-by: Muhammad Falak R Wani --- crypto/algif_skcipher.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/crypto/algif_skcipher.c b/crypto/algif_skcipher.c index 28556fc..a668867 100644 --- a/crypto/algif_skcipher.c +++ b/crypto/algif_skcipher.c @@ -489,7 +489,7 @@ static int skcipher_all_sg_nents(struct skcipher_ctx *ctx) sg = sgl->sg; while (!sg->length) - sg++; + sg = sg_next(sg); nents += sg_nents(sg); } @@ -553,7 +553,7 @@ static int skcipher_recvmsg_async(struct socket *sock, struct msghdr *msg, sg = sgl->sg; while (!sg->length) - sg++; + sg = sg_next(sg); used = min_t(unsigned long, ctx->used, iov_iter_count(&msg->msg_iter)); @@ -676,7 +676,7 @@ static int skcipher_recvmsg_sync(struct socket *sock, struct msghdr *msg, sg = sgl->sg; while (!sg->length) - sg++; + sg = sg_next(sg); skcipher_request_set_crypt(&ctx->req, sg, ctx->rsgl.sg, used, ctx->iv); -- 1.9.1