From: Kangjie Lu <kangjielu@gmail.com>
To: jlayton@poochiereds.net
Cc: bfields@fieldses.org, viro@zeniv.linux.org.uk,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
taesoo@gatech.edu, insu@gatech.edu, Kangjie Lu <kjlu@gatech.edu>
Subject: [PATCH] fix infoleak in fcntl
Date: Tue, 3 May 2016 16:34:09 -0400 [thread overview]
Message-ID: <1462307649-5833-1-git-send-email-kjlu@gatech.edu> (raw)
The stack object “si” has a total size of 128 bytes; however, only
16 bytes are initialized. The remaining uninitialized bytes are
sent to userland via send_signal.
Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
---
fs/fcntl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/fcntl.c b/fs/fcntl.c
index 350a2c8..d06f943 100644
--- a/fs/fcntl.c
+++ b/fs/fcntl.c
@@ -468,6 +468,7 @@ static void send_sigio_to_task(struct task_struct *p,
delivered even if we can't queue. Failure to
queue in this case _should_ be reported; we fall
back to SIGIO in that case. --sct */
+ memset(&si, 0, sizeof(si));
si.si_signo = signum;
si.si_errno = 0;
si.si_code = reason;
--
1.9.1
next reply other threads:[~2016-05-03 20:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 20:34 Kangjie Lu [this message]
2016-05-08 10:41 ` Christoph Hellwig
2016-05-08 12:58 ` Richard Weinberger
[not found] <CABEk9Yy6qa+B0BuGAr8ERuojtmKJgB0SHcm3OD50gCPUqX=O+g@mail.gmail.com>
2016-05-08 21:01 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462307649-5833-1-git-send-email-kjlu@gatech.edu \
--to=kangjielu@gmail.com \
--cc=bfields@fieldses.org \
--cc=insu@gatech.edu \
--cc=jlayton@poochiereds.net \
--cc=kjlu@gatech.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=taesoo@gatech.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®