From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757415AbcEDJbJ (ORCPT ); Wed, 4 May 2016 05:31:09 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:36506 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757363AbcEDJbG (ORCPT ); Wed, 4 May 2016 05:31:06 -0400 Message-ID: <1462354262.27858.153.camel@nexus-software.ie> Subject: Re: [PATCH v3 09/11] serial: 8250_lpss: move Quark code from PCI driver From: "Bryan O'Donoghue" To: Andy Shevchenko , Peter Hurley , linux-serial@vger.kernel.org, Vinod Koul , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Greg Kroah-Hartman , ismo.puustinen@intel.com, Heikki Krogerus Date: Wed, 04 May 2016 10:31:02 +0100 In-Reply-To: <1461764894-14891-10-git-send-email-andriy.shevchenko@linux.intel.com> References: <1461764894-14891-1-git-send-email-andriy.shevchenko@linux.intel.com> <1461764894-14891-10-git-send-email-andriy.shevchenko@linux.intel.com> Organization: Nexus Software Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1ubuntu3.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-04-27 at 16:48 +0300, Andy Shevchenko wrote: > Intel Quark has DesignWare UART. Move the code from 8250_pci to > 8250_lpss. > > Signed-off-by: Andy Shevchenko > --- > drivers/tty/serial/8250/8250_lpss.c | 11 +++++++++++ > drivers/tty/serial/8250/8250_pci.c | 15 +-------------- > 2 files changed, 12 insertions(+), 14 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_lpss.c > b/drivers/tty/serial/8250/8250_lpss.c > index 3112e8b..af34189 100644 > --- a/drivers/tty/serial/8250/8250_lpss.c > +++ b/drivers/tty/serial/8250/8250_lpss.c Andy, If you are going to start removing working PCI devices from the PCI config table in favour of a shim in SERIAL_8250_LPSS then the very minimum should be some sort of dependency link between SERIAL_8250_LPSS and CONFIG_SERIAL_8250_PCI in kconfig. A user could reasonably read the QRK datasheet - switch on CONFIG_SERIAL_8250_PCI and then wonder why no console output happened on boot. S/he shouldn't have to know that devices were moved from the PCI driver to an LPSS shim driver or that the 8250_lpss driver now needs to be selected instead of the intuitively correct 8250_pci driver. So assuming you agree with that (profound and sublime) logic and will make that dependency linkage then this is fine for me from a QRK POV. Reviewed-by: Bryan O'Donoghue