From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757715AbcEDLRb (ORCPT ); Wed, 4 May 2016 07:17:31 -0400 Received: from conuserg-10.nifty.com ([210.131.2.77]:24290 "EHLO conuserg-10.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757197AbcEDLRa (ORCPT ); Wed, 4 May 2016 07:17:30 -0400 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com u44BGoPD004867 X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-kernel@vger.kernel.org, Philipp Zabel Cc: Arnd Bergmann , Masahiro Yamada Subject: [PATCH] reset: allow to pass NULL pointer to reset_control_put() Date: Wed, 4 May 2016 20:17:51 +0900 Message-Id: <1462360671-13668-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently, reset_control_put() just returns for error pointer, but not for NULL pointer. This is not reasonable. Passing NULL pointer should be allowed as well to make failure path handling easier. Signed-off-by: Masahiro Yamada --- drivers/reset/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/reset/core.c b/drivers/reset/core.c index 181b05d..7bb16d1 100644 --- a/drivers/reset/core.c +++ b/drivers/reset/core.c @@ -288,7 +288,7 @@ EXPORT_SYMBOL_GPL(reset_control_get); void reset_control_put(struct reset_control *rstc) { - if (IS_ERR(rstc)) + if (IS_ERR_OR_NULL(rstc)) return; module_put(rstc->rcdev->owner); -- 1.9.1