From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751898AbcEDOS2 (ORCPT ); Wed, 4 May 2016 10:18:28 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:38212 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750825AbcEDOS0 (ORCPT ); Wed, 4 May 2016 10:18:26 -0400 From: Sasha Levin To: james.l.morris@oracle.com, serge@hallyn.com Cc: keescook@chromium.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Sasha Levin Subject: [PATCH] Yama: use atomic allocations when reporting Date: Wed, 4 May 2016 10:18:15 -0400 Message-Id: <1462371495-7984-1-git-send-email-sasha.levin@oracle.com> X-Mailer: git-send-email 2.5.0 X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Access reporting often happens from atomic contexes. Avoid lockups when allocating memory for command lines. Fixes: 8a56038c2ae ("Yama: consolidate error reporting") Signed-off-by: Sasha Levin --- security/yama/yama_lsm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/security/yama/yama_lsm.c b/security/yama/yama_lsm.c index c19f6e5..9b756b1 100644 --- a/security/yama/yama_lsm.c +++ b/security/yama/yama_lsm.c @@ -47,8 +47,8 @@ static void report_access(const char *access, struct task_struct *target, { char *target_cmd, *agent_cmd; - target_cmd = kstrdup_quotable_cmdline(target, GFP_KERNEL); - agent_cmd = kstrdup_quotable_cmdline(agent, GFP_KERNEL); + target_cmd = kstrdup_quotable_cmdline(target, GFP_ATOMIC); + agent_cmd = kstrdup_quotable_cmdline(agent, GFP_ATOMIC); pr_notice_ratelimited( "ptrace %s of \"%s\"[%d] was attempted by \"%s\"[%d]\n", -- 1.9.1