mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: hchrzani <hubert.chrzaniuk@intel.com>
To: hubert.chrzaniuk@intel.com, lukasz.anaczkowski@intel.com,
	tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	x86@kernel.org, peterz@infradead.org, kan.liang@intel.com,
	vthakkar1994@gmail.com, bp@suse.de, harish.chegondi@intel.com,
	izumi.taku@jp.fujitsu.com, linux-kernel@vger.kernel.org
Cc: Lawrence F Meadows <lawrence.f.meadows@intel.com>
Subject: [PATCH] perf/x86/intel/uncore: Fix CHA registers configuration procedure for Knights Landing platform
Date: Fri,  6 May 2016 10:59:31 +0200	[thread overview]
Message-ID: <1462525171-14643-1-git-send-email-hubert.chrzaniuk@intel.com> (raw)

CHA events in Knights Landing platform require programming filter registers properly.
Before change, code lacked mandatory bitset operations for reserved bits.
As a result some events were not counted.

Fixes: 77af003 ('perf/x86/intel/uncore: Add Knights Landing uncore PMU support')
Signed-off-by: Hubert Chrzaniuk <hubert.chrzaniuk@intel.com>
Signed-off-by: Lawrence F Meadows <lawrence.f.meadows@intel.com>
---
 arch/x86/events/intel/uncore_snbep.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/events/intel/uncore_snbep.c b/arch/x86/events/intel/uncore_snbep.c
index ab2bcaa..47d7216 100644
--- a/arch/x86/events/intel/uncore_snbep.c
+++ b/arch/x86/events/intel/uncore_snbep.c
@@ -1902,6 +1902,7 @@ static int knl_cha_hw_config(struct intel_uncore_box *box,
 		reg1->reg = HSWEP_C0_MSR_PMON_BOX_FILTER0 +
 			    KNL_CHA_MSR_OFFSET * box->pmu->pmu_idx;
 		reg1->config = event->attr.config1 & knl_cha_filter_mask(idx);
+		reg1->config |= 0x23ull << 32;
 		reg1->idx = idx;
 	}
 	return 0;
-- 
1.8.3.1

             reply	other threads:[~2016-05-06  8:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-06  8:59 hchrzani [this message]
2016-05-06  9:54 ` Thomas Gleixner
2016-05-06 13:20   ` hchrzani
2016-05-07  5:47     ` Ingo Molnar
2016-05-09  7:36       ` [PATCH v3] perf/x86/intel/uncore: Fix CHA registers configuration Hubert Chrzaniuk
2016-05-09  7:36         ` [PATCH] perf/x86/intel/uncore: Fix CHA registers configuration procedure for Knights Landing platform Hubert Chrzaniuk
2016-05-12 10:33           ` [tip:perf/core] " tip-bot for hchrzani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1462525171-14643-1-git-send-email-hubert.chrzaniuk@intel.com \
    --to=hubert.chrzaniuk@intel.com \
    --cc=bp@suse.de \
    --cc=harish.chegondi@intel.com \
    --cc=hpa@zytor.com \
    --cc=izumi.taku@jp.fujitsu.com \
    --cc=kan.liang@intel.com \
    --cc=lawrence.f.meadows@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukasz.anaczkowski@intel.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=vthakkar1994@gmail.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®