mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ayaka <ayaka@soulik.info>
To: linux-kernel@vger.kernel.org
Cc: m.szyprowski@samsung.com, nicolas.dufresne@collabora.com,
	shuahkh@osg.samsung.com, javier@osg.samsung.com,
	mchehab@osg.samsung.com, k.debski@samsung.com,
	jtp.park@samsung.com, kyungmin.park@samsung.com,
	linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org, ayaka <ayaka@soulik.info>
Subject: [PATCH 2/3] [media] s5p-mfc: remove unnecessary check in try_fmt
Date: Sat,  7 May 2016 13:05:25 +0800	[thread overview]
Message-ID: <1462597526-31559-3-git-send-email-ayaka@soulik.info> (raw)
In-Reply-To: <1462597526-31559-1-git-send-email-ayaka@soulik.info>

We don't need to request the sizeimage or num_planes
in try_fmt.

Signed-off-by: ayaka <ayaka@soulik.info>
---
 drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
index a66a9f9..2f76aba 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
@@ -1043,10 +1043,6 @@ static int vidioc_try_fmt(struct file *file, void *priv, struct v4l2_format *f)
 			mfc_err("failed to try output format\n");
 			return -EINVAL;
 		}
-		if (pix_fmt_mp->plane_fmt[0].sizeimage == 0) {
-			mfc_err("must be set encoding output size\n");
-			return -EINVAL;
-		}
 		if ((dev->variant->version_bit & fmt->versions) == 0) {
 			mfc_err("Unsupported format by this MFC version.\n");
 			return -EINVAL;
@@ -1060,11 +1056,6 @@ static int vidioc_try_fmt(struct file *file, void *priv, struct v4l2_format *f)
 			mfc_err("failed to try output format\n");
 			return -EINVAL;
 		}
-
-		if (fmt->num_planes != pix_fmt_mp->num_planes) {
-			mfc_err("failed to try output format\n");
-			return -EINVAL;
-		}
 		if ((dev->variant->version_bit & fmt->versions) == 0) {
 			mfc_err("Unsupported format by this MFC version.\n");
 			return -EINVAL;
-- 
2.5.5

  parent reply	other threads:[~2016-05-07  5:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-07  5:05 [RESEND PATCH] [PATCH 0/3] A few patches make s5p-mfc work with Gstreamer ayaka
2016-05-07  5:05 ` [PATCH 1/3] [media] s5p-mfc: Add handling of buffer freeing reqbufs request ayaka
2016-05-07  5:05 ` ayaka [this message]
2016-05-07  5:05 ` [PATCH 3/3] [media] s5p-mfc: fix a typo in s5p_mfc_dec ayaka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1462597526-31559-3-git-send-email-ayaka@soulik.info \
    --to=ayaka@soulik.info \
    --cc=javier@osg.samsung.com \
    --cc=jtp.park@samsung.com \
    --cc=k.debski@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mchehab@osg.samsung.com \
    --cc=nicolas.dufresne@collabora.com \
    --cc=shuahkh@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®