From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753345AbcEIHxx (ORCPT ); Mon, 9 May 2016 03:53:53 -0400 Received: from ozlabs.org ([103.22.144.67]:50140 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750961AbcEIHxj (ORCPT ); Mon, 9 May 2016 03:53:39 -0400 Message-ID: <1462780410.32643.1.camel@ellerman.id.au> Subject: Re: perf tools: add support for generating bpf prologue on powerpc From: Michael Ellerman To: "Naveen N. Rao" Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Arnaldo Carvalho de Melo , Wang Nan , Masami Hiramatsu , Ian Munsie Date: Mon, 09 May 2016 17:53:30 +1000 In-Reply-To: <20160507111347.GP7880@naverao1-tp.in.ibm.com> References: <1462461799-17518-1-git-send-email-naveen.n.rao@linux.vnet.ibm.com> <3r1wL02fWFz9t3k@ozlabs.org> <20160507111347.GP7880@naverao1-tp.in.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1ubuntu3.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2016-05-07 at 16:43 +0530, Naveen N. Rao wrote: > On 2016/05/07 02:15PM, Michael Ellerman wrote: > > On Thu, 2016-05-05 at 15:23:19 UTC, "Naveen N. Rao" wrote: > > > Generalize existing macros to serve the purpose. > > > > > > Cc: Wang Nan > > > Cc: Arnaldo Carvalho de Melo > > > Cc: Masami Hiramatsu > > > Cc: Ian Munsie > > > Cc: Michael Ellerman > > > Signed-off-by: Naveen N. Rao > > > --- > > > With this patch: > > > # ./perf test 37 > > > 37: Test BPF filter : > > > 37.1: Test basic BPF filtering : Ok > > > 37.2: Test BPF prologue generation : Ok > > > 37.3: Test BPF relocation checker : Ok > > > > > > tools/perf/arch/powerpc/Makefile | 1 + > > > tools/perf/arch/powerpc/util/dwarf-regs.c | 40 +++++++++++++++++++++---------- > > > 2 files changed, 29 insertions(+), 12 deletions(-) > > > > Looks feasible, and is in powerpc only code, should I take this or acme? > > Hi Michael, > Arnaldo has already pulled this in: > http://article.gmane.org/gmane.linux.kernel/2216051 Ah sorry. > It would be good if you can consider user stackdump as that depends on > perf regs support which you have added to powerpc-next: > http://thread.gmane.org/gmane.linux.kernel/2210299/focus=2210749 Yep I did, it's in next. https://git.kernel.org/cgit/linux/kernel/git/powerpc/linux.git/commit/?h=next&id=826dccfd238c3eeac379f5f637e5a3ddc7a4bc22 cheers