From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751540AbcEJLKF (ORCPT ); Tue, 10 May 2016 07:10:05 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:40312 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751511AbcEJLKC (ORCPT ); Tue, 10 May 2016 07:10:02 -0400 Message-ID: <1462878595.3050.6.camel@pengutronix.de> Subject: Re: [PATCH 5/5] clk: hisilicon: hi3519: add driver remove path and fix some issues From: Philipp Zabel To: Jiancheng Xue Cc: mturquette@baylibre.com, sboyd@codeaurora.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, yanhaifeng@hisilicon.com, haojian.zhuang@linaro.org, zhangfei.gao@linaro.org, xuwei5@hisilicon.com, yanghongwei@hisilicon.com Date: Tue, 10 May 2016 13:09:55 +0200 In-Reply-To: <1462871953-26606-6-git-send-email-xuejiancheng@hisilicon.com> References: <1462871953-26606-1-git-send-email-xuejiancheng@hisilicon.com> <1462871953-26606-6-git-send-email-xuejiancheng@hisilicon.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, den 10.05.2016, 17:19 +0800 schrieb Jiancheng Xue: > 1. Add driver remove path. > 2. Fix some issues. > -Fix the ordering issue about clock provider being published. > -Add error checking upon registering clocks. > > Signed-off-by: Jiancheng Xue > --- > drivers/clk/hisilicon/clk-hi3519.c | 116 ++++++++++++++++++++++++++++++++----- > 1 file changed, 100 insertions(+), 16 deletions(-) > > diff --git a/drivers/clk/hisilicon/clk-hi3519.c b/drivers/clk/hisilicon/clk-hi3519.c > index 715c730..51b173e 100644 > --- a/drivers/clk/hisilicon/clk-hi3519.c > +++ b/drivers/clk/hisilicon/clk-hi3519.c [...] > - rstc = hisi_reset_init(np); > - if (!rstc) [...] > + crg->rstc = hisi_reset_init(pdev); > + if (!crg->rstc) [...] The hisi_reset_init(np) -> hisi_reset_init(pdev) change should be part of patch 1. regards Philipp